OpenStack Heat

contrib/ is not being checking for flake8 in gating

Bug #1234938 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Steve Baker
OpenStack Heat 2014.1 "icehouse"

Bug Description

tox.ini is not including contrib for flake8 checks, which is not consistent with run_tests.sh

Steve Baker (steve-stevebaker)
Changed in heat:
importance: Undecided → Low
assignee: nobody → Steve Baker (steve-stevebaker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49635

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/49635
Committed: http://github.com/openstack/heat/commit/6f81001f269c7326be2c0a3203fab4cd0a323232
Submitter: Jenkins
Branch: master

commit 6f81001f269c7326be2c0a3203fab4cd0a323232
Author: Steve Baker <email address hidden>
Date: Fri Oct 4 10:06:45 2013 +1300

    Add contrib to tox pep8 check

    This implements Clint's comment in
    https://review.openstack.org/#/c/48690/1 adding # noqa
    to the relative imports and adding contrib to the pep8 check.

    run_tests.sh -p now returns no warnings.

    Change-Id: I05085151258a6d0f3cc348211f64533fd4cbded9
    Closes-Bug: #1234938

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.