Fail to delete a floating IP address that doesn't exist anymore

[Simon Pasquier]

https://github.com/openstack/heat/blob/master/heat/engine/resources/eip.py#L121

There is no try/except to catch a clients.novaclient.exceptions.NotFound exception.

[Xiang Hui (xianghui)]

Hi Steven, can I solve this bug? Cause I have committed a patch dup as this bug. https://bugs.launchpad.net/heat/+bug/1237271

[Steven Dake (sdake)]

Xiang,

Feel free to take the bug.

[Xiang Hui (xianghui)]

Thanks Steve.

[Steven Hardy (shardy)]

Patch for this is https://review.openstack.org/#/c/50577/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50577
Committed: http://github.com/openstack/heat/commit/e1c4ab30dcd736e031d784308ae214837566c8cf
Submitter: Jenkins
Branch: master

commit e1c4ab30dcd736e031d784308ae214837566c8cf
Author: Hui HX Xiang <email address hidden>
Date: Wed Oct 9 03:10:36 2013 -0700

    Fix heat deletion failed if floating ip is not found

    Novaclient will throw out a Not Found exception if the
    floating ip not exists. Heat should catch this exception
    to continue to delete the stack.

    Closes-Bug: #1234593

    Change-Id: Ifd9d34de37cc5dd57804787d8b1455f0321fc86f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/51363

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51363
Committed: http://github.com/openstack/heat/commit/2aa4186dde97e580694b88ad22dad4db657cc5ad
Submitter: Jenkins
Branch: milestone-proposed

commit 2aa4186dde97e580694b88ad22dad4db657cc5ad
Author: Hui HX Xiang <email address hidden>
Date: Wed Oct 9 03:10:36 2013 -0700

    Fix heat deletion failed if floating ip is not found

    Novaclient will throw out a Not Found exception if the
    floating ip not exists. Heat should catch this exception
    to continue to delete the stack.

    Closes-Bug: #1234593

    Change-Id: Ifd9d34de37cc5dd57804787d8b1455f0321fc86f