Renewal blocked due to holds ratio does not display block message

[Kathy Lussier]

Evergreen version: master

In testing the minimum available copy/hold ratio in master, I was able to successfully block renewals for copies that had more existing holds than available copies. However, the message that displays to the user in the staff client and in tpac is "config_circ_matrix_test_available_copy_hold_ratio."

In looking at the code, it appears that there was an intent for the message to be "The available item-to-hold ratio is too low" since this message appears both in opac.dtd and in parts/hold_error_messages.tt2.

I guess there are two parts to this bug:

config_circ_matrix_test_available_copy_hold_ratio and also config.circ_matrix_test.total_copy_hold_ratio should probably be removed from hold_error_messages.tt2. The ratios are used in the circulation matrix, not the holds matrix, and typically are used to block renewals. I can't think of any use case where they would be used to block a hold.

tpac and the staff client somehow needs to be instrumented to display this block message at renewal time.

[Joan Kranich (jkranich)]

Confirmed in 2.5.5 on 8/21/2014.

[Bill Erickson (berick)]

Self-check can perform renewals, so it may need fixing as well.

[Bill Erickson (berick)]

Scratch my last comment about self-check; confirmed it's displaying a sane message.

[Bill Erickson (berick)]

Code pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1234220-hold-ratio-renewal-warning

This includes staff client and tpac renewal failure messages (comments welcome) and total/avail hold ratio override permissions.

[Kathy Lussier (klussier)]

Works for me! I tested the messages in both tpac and the staff client and also tested the new permissions.

Signoff is available at
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1234220-hold-ratio-renewal-warning

[Bill Erickson (berick)]

Thanks, Kathy! I'll merge this next week, after others have a chance to comment. Unless there are any objections, I'll also back-port to 2.7 and 2.8.

[Bill Erickson (berick)]

Merged to 2.6 and beyond.