ML2 mechanism drivers not called for ports auto-deleted when subnet deleted

[Robert Kukura]

Similar to bug 1230330, when a subnet is deleted, ports need to be auto-deleted via the ML2 plugin code rather than at DB level by NeutronDBPLuginV2.

[Thierry Carrez (ttx)]

Master fix proposed at https://review.openstack.org/#/c/49644/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/49644
Committed: http://github.com/openstack/neutron/commit/ed78b563e13f1ed9189d7c4b9cd4317f2a50e734
Submitter: Jenkins
Branch: master

commit ed78b563e13f1ed9189d7c4b9cd4317f2a50e734
Author: Bob Kukura <email address hidden>
Date: Thu Oct 3 12:25:24 2013 -0400

    Fix auto-deletion of ports when deleting subnets in ML2

    When a subnet is deleted, certain ports referencing it are
    auto-deleted. The implementation of NeutronDBPluginV2.delete_subnet()
    does this at the DB level, so ML2's mechanism drivers were not being
    called.

    Ml2Plugin.delete_subnet() is changed to not use the base class's
    method, and to auto-delete ports by calling its own delete_port()
    method outside of the transaction. A loop avoids race conditions with
    ports being asynchronously added to the subnet.

    The logic in Ml2Plugin.delete_network() is also fixed to properly
    handle auto-deleting ports and subnets, and debug logging is added to
    the various delete methods.

    Closes-Bug: 1234195
    Partial-Bug: 1235486
    Change-Id: I6d74f89d39ea8afe6915f1d2f9afdf66c0076f5a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/51303

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/51303
Committed: http://github.com/openstack/neutron/commit/bfe1dca0563cd5beadf91e3688924c44f5063778
Submitter: Jenkins
Branch: milestone-proposed

commit bfe1dca0563cd5beadf91e3688924c44f5063778
Author: Bob Kukura <email address hidden>
Date: Thu Oct 3 12:25:24 2013 -0400

    Fix auto-deletion of ports when deleting subnets in ML2

    When a subnet is deleted, certain ports referencing it are
    auto-deleted. The implementation of NeutronDBPluginV2.delete_subnet()
    does this at the DB level, so ML2's mechanism drivers were not being
    called.

    Ml2Plugin.delete_subnet() is changed to not use the base class's
    method, and to auto-delete ports by calling its own delete_port()
    method outside of the transaction. A loop avoids race conditions with
    ports being asynchronously added to the subnet.

    The logic in Ml2Plugin.delete_network() is also fixed to properly
    handle auto-deleting ports and subnets, and debug logging is added to
    the various delete methods.

    Closes-Bug: 1234195
    Partial-Bug: 1235486
    Change-Id: I6d74f89d39ea8afe6915f1d2f9afdf66c0076f5a
    (cherry picked from commit ed78b563e13f1ed9189d7c4b9cd4317f2a50e734)