OpenStack Compute (nova)

VHD format check is not properly performed for fixed disks in the Hyper-V driver

Bug #1233853 reported by Alessandro Pilotti
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Alessandro Pilotti
OpenStack Compute (nova) 2014.1 "icehouse"
Havana
Fix Released
Undecided
Lucian Petrut
OpenStack Compute (nova) 2013.2.4

Bug Description

By the VHD specs, fixed disks don't have a copy of the footer at the beginning of the file:

http://download.microsoft.com/download/f/f/e/ffef50a5-07dd-4cf8-aaa3-442c0673a029/Virtual%20Hard%20Disk%20Format%20Spec_10_18_06.doc

See original description
Alessandro Pilotti (alexpilotti)
tags: added: hyper-v
tags: added: havana-rc-potential
Alessandro Pilotti (alexpilotti)
summary: - VHD format footer copy is not created properly by the Microsoft VHDTool
- utility
+ VHD format check is not properly performed for fixed disks in the
+ Hyper-V driver
description: updated
Alessandro Pilotti (alexpilotti)
Changed in nova:
assignee: nobody → Alessandro Pilotti (alexpilotti)
OpenStack Infra (hudson-openstack)
Changed in nova:
status: New → In Progress
Alessandro Pilotti (alexpilotti)
Changed in nova:
importance: Undecided → High
Thierry Carrez (ttx)
tags: added: havana-backport-potential
removed: havana-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/49269
Committed: http://github.com/openstack/nova/commit/fdc5a57d03b9a53981dc0e1623091980570456eb
Submitter: Jenkins
Branch: master

commit fdc5a57d03b9a53981dc0e1623091980570456eb
Author: Alessandro Pilotti <email address hidden>
Date: Wed Oct 2 00:39:09 2013 +0300

    Fixes Hyper-V issue with VHD file format

    The VHD format cookie signature needs to be checked in the footer
    instead of the header as fixed format VHDs don't have a copy of the
    footer at the beginning of the file.

    Fixes bug: #1233853

    Change-Id: Ibe44f0d895cde2edbc03dcd6ecebac24b0936660

Changed in nova:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/83360

Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/110700

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/havana)

Change abandoned by Petrut Lucian (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/83360

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/110700
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4b38f3e59bd7ead2cd279563164a3a2a7989b6b4
Submitter: Jenkins
Branch: stable/havana

commit 4b38f3e59bd7ead2cd279563164a3a2a7989b6b4
Author: Alessandro Pilotti <email address hidden>
Date: Wed Oct 2 00:39:09 2013 +0300

    Fixes Hyper-V issue with VHD file format

    The VHD format cookie signature needs to be checked in the footer
    instead of the header as fixed format VHDs don't have a copy of the
    footer at the beginning of the file.

    Fixes bug: #1233853

    (cherry-picked from commit fdc5a57d03b9a53981dc0e1623091980570456eb)

    Conflicts:

     nova/tests/virt/hyperv/test_vhdutils.py

    Change-Id: Ibe44f0d895cde2edbc03dcd6ecebac24b0936660

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.