OpenStack Compute (nova)

Object actions via conductor will result in verbose exception logging

Bug #1233789 reported by David Kranz
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Dan Smith
OpenStack Compute (nova) 2013.2 "havana"
Revision history for this message
Dan Smith (danms) wrote :

I'm going to change the title of this bug to something useful, which represents the majority (or all) of the conductor traces in the given log.

summary: - "Exception during message handling" in n-cond log after good tempest run
+ Object actions via conductor will result in verbose exception loggin
summary: - Object actions via conductor will result in verbose exception loggin
+ Object actions via conductor will result in verbose exception logging
Changed in nova:
assignee: nobody → Dan Smith (danms)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49245

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/49245
Committed: http://github.com/openstack/nova/commit/3a5e1faee04671f2e88b28d805b191b480054254
Submitter: Jenkins
Branch: master

commit 3a5e1faee04671f2e88b28d805b191b480054254
Author: Dan Smith <email address hidden>
Date: Tue Oct 1 12:12:13 2013 -0700

    Avoid spamming conductor logs with object exceptions

    Conductor's logs should include tracebacks only when something
    unexpected happened, which is why we have the client_exceptions()
    decorator. The object_action() and object_class_action() methods
    are used for direct remoting of object methods, and thus really
    should forward *any* exception to the client.

    This patch does that, and also adds missing tests for these two
    methods to verify the normal and exception-wrapped behavior.

    Closes-bug: #1233789
    Closes-bug: #1084706
    Change-Id: I505462fa429a6aa68e7b8a08ec2b704bf18d029c

Changed in nova:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in nova:
milestone: none → havana-rc2
importance: Low → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/51075

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (milestone-proposed)

Reviewed: https://review.openstack.org/51075
Committed: http://github.com/openstack/nova/commit/b64ea7c2cb76c476a178deeed6ab9e83676faf05
Submitter: Jenkins
Branch: milestone-proposed

commit b64ea7c2cb76c476a178deeed6ab9e83676faf05
Author: Dan Smith <email address hidden>
Date: Tue Oct 1 12:12:13 2013 -0700

    Avoid spamming conductor logs with object exceptions

    Conductor's logs should include tracebacks only when something
    unexpected happened, which is why we have the client_exceptions()
    decorator. The object_action() and object_class_action() methods
    are used for direct remoting of object methods, and thus really
    should forward *any* exception to the client.

    This patch does that, and also adds missing tests for these two
    methods to verify the normal and exception-wrapped behavior.

    Closes-bug: #1233789
    Closes-bug: #1084706
    Change-Id: I505462fa429a6aa68e7b8a08ec2b704bf18d029c
    (cherry picked from commit 3a5e1faee04671f2e88b28d805b191b480054254)

Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.