juju test suite should be isolated and do 0 outbound network requests

Bug #1233601 reported by William Reade
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Ian Booth

Bug Description

http://paste.ubuntu.com/6178801/

Well, I see how, but not how the code landed like that. Skipping them for now.

Related branches

William Reade (fwereade)
Changed in juju-core:
milestone: none → 1.16.0
Revision history for this message
John A Meinel (jameinel) wrote :

The code worked before because there wasn't anything in the public s3 bucket for simplestreams data.

Then we uploaded the 1.15 release, and the permissions were wrong, so it searched and some tests started failing. We fixed the permissions, and now the tests that were running are seeing real data and failing.

Revision history for this message
John A Meinel (jameinel) wrote :

Note that I don't think we'll actually block a 1.16 release on fixing it. It *is* important for our ongoing development work, but as it is a test-suite issue not a user-facing issue it isn't a release blocker.

Revision history for this message
John A Meinel (jameinel) wrote :

We've landed what we need for 1.16 on this, but we need to have some time to ensure our test suite doesn't try to dial a remote machine. That doesn't need to block a release, though, because in production we really do want it to dial out :).

Changed in juju-core:
milestone: 1.16.0 → none
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: none → 1.17.0
importance: Critical → High
Curtis Hovey (sinzui)
tags: added: test-failure testing
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.17.0 → 1.19.0
John A Meinel (jameinel)
summary: - cmd/juju ActualRun tests failing on trunk (how!?)
+ juju test suite should be isolated and do 0% outbound network requests
summary: - juju test suite should be isolated and do 0% outbound network requests
+ juju test suite should be isolated and do 0 outbound network requests
Revision history for this message
Andrew Wilkins (axwalk) wrote :

I think it'd be a good idea to block outbound network access on the bot, to prevent these things in the future. We can do this with something like:

    sudo unshare -n bash <<EOF
    ifconfig lo up
    su - $SUDO_USER -c "make check"
    EOF

Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.19.0 → 2.0
Ian Booth (wallyworld)
Changed in juju-core:
milestone: 2.0 → 1.19.3
Ian Booth (wallyworld)
Changed in juju-core:
assignee: nobody → Ian Booth (wallyworld)
status: Triaged → In Progress
Ian Booth (wallyworld)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.