OpenStack Compute (nova)

virt.libvirt.get_disk_bus_for_disk_dev is missing unit tests

Bug #1233235 reported by Nikola Đipanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sahid Orentino
OpenStack Compute (nova) 2014.1 "icehouse"

Bug Description

We should add unit tests for this function as it seems to have non-trivial logic that can also raise exceptions, even though it is tested by the unit tests of the functions that call it.

Nikola Đipanov (ndipanov)
Changed in nova:
importance: Undecided → Low
tags: added: low-hanging-fruit
Sahid Orentino (sahid-ferdjaoui)
Changed in nova:
assignee: nobody → sahid (sahid-ferdjaoui)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/54931
Committed: http://github.com/openstack/nova/commit/8c8b00ce0268fc55d581c6484f11f7f4b1fd235c
Submitter: Jenkins
Branch: master

commit 8c8b00ce0268fc55d581c6484f11f7f4b1fd235c
Author: Pekelny "I159" Ilya <email address hidden>
Date: Fri Nov 1 16:38:40 2013 +0200

    Added tests for get_disk_bus_for_disk_dev function

    Testing get_disk_bus_for_disk_dev function for appropriate and inappropriate
    arguments.

    Change-Id: I394d603a0105d4b13d4bc9fe8b7f6fe852c536ab
    Closes-Bug: #1233235

Changed in nova:
status: Confirmed → Fix Committed
Russell Bryant (russellb)
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.