virt.libvirt.get_disk_bus_for_disk_dev is missing unit tests
Bug #1233235 reported by
Nikola Đipanov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
Sahid Orentino |
Bug Description
We should add unit tests for this function as it seems to have non-trivial logic that can also raise exceptions, even though it is tested by the unit tests of the functions that call it.
Changed in nova: | |
importance: | Undecided → Low |
tags: | added: low-hanging-fruit |
Changed in nova: | |
assignee: | nobody → sahid (sahid-ferdjaoui) |
status: | New → Confirmed |
Changed in nova: | |
milestone: | none → icehouse-1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-1 → 2014.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/54931 github. com/openstack/ nova/commit/ 8c8b00ce0268fc5 5d581c6484f11f7 f4b1fd235c
Committed: http://
Submitter: Jenkins
Branch: master
commit 8c8b00ce0268fc5 5d581c6484f11f7 f4b1fd235c
Author: Pekelny "I159" Ilya <email address hidden>
Date: Fri Nov 1 16:38:40 2013 +0200
Added tests for get_disk_ bus_for_ disk_dev function
Testing get_disk_ bus_for_ disk_dev function for appropriate and inappropriate
arguments.
Change-Id: I394d603a0105d4 b13d4bc9fe8b7f6 fe852c536ab
Closes-Bug: #1233235