Video & music renderers are not to spec
Bug #1231937 reported by
Michał Sawicz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Released
|
Undecided
|
Xi Zhu | ||
| unity8 (Ubuntu) |
Fix Released
|
High
|
Andrea Cimitan | ||
Bug Description
In accordance with the video scope spec, videos in the dash should be "mounted", but UbuntuShape doesn't support it yet (bug #1157720), so let's go for mounting on black. There should also be two lines of left-aligned text underneath.
desired solution
-----------------
See visual design spec
https:/
The music grid renderer is quite similar, the only difference is that there's space for 3 lines of text and there's no extra background for the images.
Related branches
lp:~unity-team/unity8/music-video_renderers
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Albert Astals Cid (community): Approve
-
Diff: 417 lines (+241/-50)9 files modifiedComponents/Tile.qml (+1/-2)
Components/TileStyle.qml (+4/-3)
Dash/Generic/FlatTileStyle.qml (+4/-3)
Dash/GenericScopeView.qml (+1/-1)
Dash/Music/MusicFilterGrid.qml (+25/-26)
Dash/Music/MusicTileStyle.qml (+101/-0)
Dash/Video/VideoFilterGrid.qml (+18/-14)
Dash/Video/VideoTileStyle.qml (+86/-0)
tests/qmltests/Dash/tst_FilterGrids.qml (+1/-1)
lp:~cimi/unity8/carousel-music-video
- Michał Sawicz: Disapprove
- PS Jenkins bot (community): Approve (continuous-integration)
- Michael Zanetti (community): Needs Fixing
-
Diff: 216 lines (+127/-27)4 files modifiedDash/Music/CarouselDelegateMusic.qml (+59/-13)
Dash/Video/CarouselDelegateVideo.qml (+64/-10)
Dash/Video/VideoCarousel.qml (+2/-2)
Dash/Video/VideoTileStyle.qml (+2/-2)
| Changed in ubuntu-ux: | |
| status: | New → Fix Committed |
| assignee: | nobody → Xi Zhu (xi.zhu) |
| description: | updated |
| summary: |
- Video renderer is not to spec + Video & music renderers are not to spec |
| description: | updated |
| Changed in unity8: | |
| milestone: | ubuntu-13.09 → phone-v1-freeze |
| Changed in unity8: | |
| status: | Triaged → In Progress |
| Changed in unity8: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
| Changed in unity8: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Fix Released → Fix Committed |
| Changed in unity8: | |
| status: | Fix Released → In Progress |
Revision history for this message
| Michał Sawicz (saviq) wrote | #1 |
| Changed in unity8: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → In Progress |
| tags: | added: needs-qml-test |
Revision history for this message
| Andrea Cimitan (cimi) wrote | #2 |
| Changed in unity8 (Ubuntu): | |
| status: | New → In Progress |
| Changed in unity8: | |
| status: | In Progress → Fix Released |
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Andrea Cimitan (cimi) |
| importance: | Undecided → High |
| no longer affects: | unity8 |
To post a comment you must log in.
Videos carousel is still not using the mount, and songs don't have title overlay.