Next datatables update can occur before previous AJAX request completes

Bug #1231751 reported by Janet Yu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Janet Yu

Bug Description

In horizon.tables.js, datatables is updated every next_poll milliseconds. If the AJAX request made in the previous call takes longer than next_poll milliseconds to complete, the two requests could return out of order. Also, there could be unexpected results if the first request modifies data after the second request has been made and now the second request has stale data.

Janet Yu (jwy)
Changed in horizon:
assignee: nobody → Janet Yu (jwy)
Changed in horizon:
importance: Undecided → Medium
milestone: none → icehouse-1
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49645

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/49645
Committed: http://github.com/openstack/horizon/commit/999729f17f2f622469fab34c0dd2311f04feb704
Submitter: Jenkins
Branch: master

commit 999729f17f2f622469fab34c0dd2311f04feb704
Author: Janet Yu <email address hidden>
Date: Thu Oct 3 14:21:26 2013 -0700

    Update DataTables only after previous call is done

    When the update is always made at a set interval, the next update could
    be called before the previous one has completed. Data inconsistencies
    could arise from changes being made out of order in the updates. Move
    the code to call the next update to the "complete" function to make sure
    the previous call has finished before starting the next one.

    Change-Id: I946912a30934e8d25f83fadaef7c2b8b6db269b2
    Closes-Bug: #1231751

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.