Method for creating an instance via Heat doesn't support availability zone

Bug #1231706 reported by Dan Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Dan Nguyen

Bug Description

trove > trove > taskmanager > models.py

https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L146

the _create_server_volume_heat(...) is passed an availability_zone param but this is not currently supported.
If the code block runs it will encounter an exception.

Changed in trove:
assignee: nobody → Dan Nguyen (daniel-a-nguyen)
Revision history for this message
Dan Nguyen (daniel-a-nguyen) wrote :

Thinking of just adding the param to the method signature without actually using it as we have several other params passed that are ignored.

def _create_server_volume_heat(self,
                                                             flavor,
                                                             image_id, # <= not used
                                                             security_groups, # <= not used
                                                             service_type, # <= not used
                                                             volume_size,
                                                             availability_zone): # <= not used

Revision history for this message
Dan Nguyen (daniel-a-nguyen) wrote :

the following params are not used

image_id
security_groups
service_type
availability_zone

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48535

Changed in trove:
status: New → In Progress
Revision history for this message
Andrey Shestakov (ashestakov) wrote :

actually guest_config and cloudinit are not used as well

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/48535
Committed: http://github.com/openstack/trove/commit/90ebcfbad1fd696d79e1a53622936ab636a93b8c
Submitter: Jenkins
Branch: master

commit 90ebcfbad1fd696d79e1a53622936ab636a93b8c
Author: daniel-a-nguyen <email address hidden>
Date: Thu Sep 26 15:17:33 2013 -0700

    Fixed method signature _create_server_volume_heat

    Change-Id: I0fbf9674c5281b37937dab941815e7afab762ef6
    Closes-Bug: #1231706

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.