copy of files between containers add a files with spaces

Bug #1231544 reported by Dafna Ron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Romain Hardouin

Bug Description

I copied a file from one swift container to a second swift container and the new file was created with spaces between the file name and "copy":

create_horizon.txt copy

I think that in linux it would be better to add underscore instead of spaces (it would make life easier for users)

Revision history for this message
Dafna Ron (dron-3) wrote :

btw, I am only talking about the default name presented - user can change it manually to what ever they want, but I think that the default should have underscore and not space

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

I'm not entirely sure always using underscores is the right solution, nor that introspection is the right thing either. However, I think the current behavior of appending " copy", particularly after the extension, isn't a good thing to do. Let's revisit this in I.

Changed in horizon:
importance: Undecided → Low
milestone: none → icehouse-1
status: New → Triaged
Changed in horizon:
assignee: nobody → Romain Hardouin (romain-hardouin)
Revision history for this message
Romain Hardouin (romain-hardouin) wrote :

We can insert a string before the extension, but which string?

Some ideas:
" copy" => example copy.pdf
"_copy" => example_copy.pdf
" - copy" => example - copy.pdf
".copy" => example.copy.pdf

David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-1 → icehouse-2
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-2 → icehouse-3
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → icehouse-rc1
Revision history for this message
Julie Pichon (jpichon) wrote :

@Romain: Any progress on this for Icehouse?

Revision history for this message
Romain Hardouin (romain-hardouin) wrote :

I was waiting for an answer concerning the string and then I forgot this ticket.
I think ".copy" => example.copy.pdf will be OK.
I will do that for Icehouse.

Revision history for this message
Julie Pichon (jpichon) wrote :

Thank you. Often discussion is more likely to happen in reviews than in the bug tracker, especially for smaller points. The solution you chose sounds fine to me.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80863

Changed in horizon:
status: Triaged → In Progress
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-rc1 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80863
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=14e6e415eb71db67226cac7faded5c05511a3fc2
Submitter: Jenkins
Branch: master

commit 14e6e415eb71db67226cac7faded5c05511a3fc2
Author: Romain Hardouin <email address hidden>
Date: Mon Mar 17 01:07:27 2014 +0100

    Add ".copy" before extension when copying a Swift object.

    When the object has no extension the string is appended to the end:
    test.pdf => test.copy.pdf
    test => test.copy

    Change-Id: I50077f6c7a7295ebb7caf7500a5738a856e6a435
    Closes-Bug: #1231544

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
milestone: next → juno-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.