copy of files between containers add a files with spaces

[Dafna Ron]

I copied a file from one swift container to a second swift container and the new file was created with spaces between the file name and "copy":

create_horizon.txt copy

I think that in linux it would be better to add underscore instead of spaces (it would make life easier for users)

[Dafna Ron (dron-3)]

btw, I am only talking about the default name presented - user can change it manually to what ever they want, but I think that the default should have underscore and not space

[Gabriel Hurley (gabriel-hurley)]

I'm not entirely sure always using underscores is the right solution, nor that introspection is the right thing either. However, I think the current behavior of appending " copy", particularly after the extension, isn't a good thing to do. Let's revisit this in I.

[Romain Hardouin (romain-hardouin)]

We can insert a string before the extension, but which string?

Some ideas:
" copy" => example copy.pdf
"_copy" => example_copy.pdf
" - copy" => example - copy.pdf
".copy" => example.copy.pdf

[Julie Pichon (jpichon)]

@Romain: Any progress on this for Icehouse?

[Romain Hardouin (romain-hardouin)]

I was waiting for an answer concerning the string and then I forgot this ticket.
I think ".copy" => example.copy.pdf will be OK.
I will do that for Icehouse.

[Julie Pichon (jpichon)]

Thank you. Often discussion is more likely to happen in reviews than in the bug tracker, especially for smaller points. The solution you chose sounds fine to me.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80863
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=14e6e415eb71db67226cac7faded5c05511a3fc2
Submitter: Jenkins
Branch: master

commit 14e6e415eb71db67226cac7faded5c05511a3fc2
Author: Romain Hardouin <email address hidden>
Date: Mon Mar 17 01:07:27 2014 +0100

    Add ".copy" before extension when copying a Swift object.

    When the object has no extension the string is appended to the end:
    test.pdf => test.copy.pdf
    test => test.copy

    Change-Id: I50077f6c7a7295ebb7caf7500a5738a856e6a435
    Closes-Bug: #1231544