"Session timed out." string doesn't disappear under certain condition

Bug #1231355 reported by Noboru Arai
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Nikunj Aggarwal

Bug Description

environment:
 * Openstack deployed by devstack
 * Firefox 23.0.1

Steps to reproduce:
  1. login as "demo" user

  2. Wait till session timeout

  3. click "overview" link

  4. login as "demo" user again after "login" page is displayed

  5. click "Sign Out" link immediately

  6. "Session timed out." string is displayed again in "login" page

Expected result:

  In step "6", "Session timed out." message is not displayed.

Remark:
 Because I find the followng, I think cooke "logout_reason" is the cause.
   * when I wait for a while(about 30 seconds) in step "5", "Session time out.
     "message is not displayed in step 6.

   * cookie "logout_reason" exists ,which expires in 30 second in Firefox.

   * when I changed password, A similar result occurs.

   * in those patterns,"add_logout_reason" method (in horizon/utils/functions.py)
     is used.

Changed in horizon:
importance: Undecided → Medium
milestone: none → icehouse-1
status: New → Confirmed
Changed in horizon:
assignee: nobody → Facundo Maldonado (facundo-n-maldonado)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57323

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Facundo Maldonado (facundo-n-maldonado) wrote : Re: "Session timed out." string does'nt disappear under certain condition

The problem is the logout_reason message is stored in the "logout_reason" cookie.
The simpler way to proceed is to reduce the max_age value of the cookie. But this do not resolve the bug.
Just reduce the probability of occurrence.

The bug is also reproducible when you refresh the login page when the session expires.
I have the fix as draft, I you agree with this solution I can propose the fix.

Changed in horizon:
status: In Progress → Confirmed
Changed in horizon:
status: Confirmed → In Progress
David Lyle (david-lyle)
summary: - "Session timed out." string does'nt disappear under certain condition
+ "Session timed out." string doesn't disappear under certain condition
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → icehouse-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60226

Changed in horizon:
assignee: Facundo Maldonado (facundo-n-maldonado) → Kieran Spear (kspear)
Kieran Spear (kspear)
Changed in horizon:
assignee: Kieran Spear (kspear) → Facundo Maldonado (facundo-n-maldonado)
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-2 → icehouse-3
Matthias Runge (mrunge)
Changed in horizon:
assignee: Facundo Maldonado (facundo-n-maldonado) → nobody
status: In Progress → Confirmed
Changed in horizon:
assignee: nobody → Facundo Maldonado (facundo-n-maldonado)
Changed in horizon:
status: Confirmed → In Progress
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → icehouse-rc1
David Lyle (david-lyle)
Changed in horizon:
milestone: icehouse-rc1 → next
Changed in horizon:
assignee: Facundo Maldonado (facundo-n-maldonado) → nobody
Julie Pichon (jpichon)
Changed in horizon:
status: In Progress → Confirmed
Changed in horizon:
assignee: nobody → Nikunj Aggarwal (nikunj2512)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/100849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Nikunj Aggarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/100849
Reason: Wrong commit

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100855

Revision history for this message
Nikunj Aggarwal (nikunj2512) wrote :

Hi Everyone,

For this bug, i have to change both horizon and openstack_auth. Please when You review one, don't miss out to review the other.

Review: https://review.openstack.org/100849

Review: https://review.openstack.org/100855

Revision history for this message
Nikunj Aggarwal (nikunj2512) wrote :

Sorry these are the correct url for the reviews

Review: https://review.openstack.org/100855
https://review.openstack.org/#/c/108616/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/100855
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e940196a4386d51f9a9c2644cea28940da48f08b
Submitter: Jenkins
Branch: master

commit e940196a4386d51f9a9c2644cea28940da48f08b
Author: nikunj2512 <email address hidden>
Date: Wed Jun 18 16:34:59 2014 +0530

    Fixes session timeout string in horizon

    1) This patch fixes the session timeout string problem which
    occurs when users clicks on the UI and Ui redirects the
    user to the login page but without session timeout message.

    2) This patch also fixes other cases of unnecessary logout
    messages.

    Closes-Bug: #1231355

    Change-Id: I9824db44382247d64cc8c399eb5e855e818e8781

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → juno-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/136813

Brant Knudson (blk-u)
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/icehouse)

Change abandoned by David Lyle (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/136813
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.