horizon.tables.Column() raises an exception for a valid arguments combination

[Timur Sufiev]

Say, if we pass some callable as first mandatory argument 'transform' of horizon.tables.Column __init__ method and do not provide 'verbose_name' optional argument, __init__ fails with an exception (I've cut off irrelevant part of stacktrace):

  File "/home/tsufiev/develop/murano-dashboard/.venv/local/lib/python2.7/site-packages/horizon/tables/base.py", line 215, in __init__
    verbose_name = self.transform.title()
AttributeError: 'function' object has no attribute 'title'

This is clearly a bug, because horizon.tables.Column should be able to derive 'verbose_name' from 'transform' even if it is callable.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/48297

[Timur Sufiev (tsufiev-x)]

I've made a fix for this issue: https://review.openstack.org/#/c/48297/

[Kieran Spear (kspear)]

I don't necessarily have an issue with this fix, but I strongly suggest providing a verbose_name for every column because otherwise the name won't be translatable.

[Timur Sufiev (tsufiev-x)]

This can be also guaranteed by making verbose_name required, not optional.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/48297
Committed: http://github.com/openstack/horizon/commit/87265bc4d66493bab04b3bdc045ae989e732cb45
Submitter: Jenkins
Branch: master

commit 87265bc4d66493bab04b3bdc045ae989e732cb45
Author: Timur Sufiev <email address hidden>
Date: Tue Oct 22 12:45:37 2013 +0400

    Fix horizon.tables.Column __init__ method.

    __init__ method currently does not work (raises an exception)
    when 'transform' arg is callable and 'verbose_name' arg is absent.
    Fixed __init__ to use "" as default for 'verbose_name' when
    'transform' is callable.

    Change-Id: I45c7cd4502e7ea8c809f05ff0ed70b4f766c17fd
    Closes-bug: #1230400