Passing mandatory args as optional to create_volume

Bug #1230069 reported by Avishay Traeger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Avishay Traeger

Bug Description

Filter scheduler and create_volume flow both pass request_specs and filter_properties as optional arguments to create_volume in volume_rpcapi. This does not fit how the call is defined.

Also, the create_volume call in the migration code in manager.py should not allow rescheduling.

Changed in cinder:
importance: Undecided → Medium
assignee: nobody → Avishay Traeger (avishay-il)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48183

Changed in cinder:
status: New → In Progress
Changed in cinder:
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/48183
Committed: http://github.com/openstack/cinder/commit/d534811cbcfe591688b5e9c6becbed2224be3c31
Submitter: Jenkins
Branch: master

commit d534811cbcfe591688b5e9c6becbed2224be3c31
Author: Avishay Traeger <email address hidden>
Date: Wed Sep 25 08:41:21 2013 +0300

    Fix mandatory and optional args for create_volume

    Calls to create_volume (both volume_rpcapi and scheduler_rpcapi) pass
    mandatory args as optional and reverse. This patch fixes the calls to be
    according to the function definition.

    Also, fix the call to create_volume in the migration code where
    allow_reschedule defaults to True, but we don't pass request_spec so it
    prints a warning and disables it.

    Change-Id: I9509f88866e0ae182f90ebdfca1fcf415ca60d19
    Closes-Bug: #1230069

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.