Remove colon in item names in LBaaS detail page

Bug #1230057 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

In all load balancer detail pages, each item name has a trailing colon.
All other detail pages do not have trailing colons.
It should be removed for consistency.

Now we are in the last moment in Havana release and translation works are almost completed in several number of languages.

----

IMO, considering the situation, it is better to delay the fix after opening Icehouse cycle.

Revision history for this message
Łukasz Jernaś (deejay1) wrote :

Copying my comment from a https://review.openstack.org/#/c/47450/:
Depends on if we can make another horizon release before final release. I'd opt for removing them after RC1 and fixup in the days before havana release. Right now it makes an inconsistency in the UI which makes horizon less of a "finished" product. If we can't do another release after RC1 at least we should fix it in a subsequent point release of Havana. Maybe it'll be best to bring up the issue on the lists?

Revision history for this message
Łukasz Jernaś (deejay1) wrote :

Also some strings will be merged with existing strings, starting from the beginning these string should be already translated when the colon will be removed:
ID
Name
Description
Subnet ID
Protocol
Load Balancing Method
Members
Admin State Up
Status

which leaves:
VIP ID, Tenant ID, Health Monitors

Provider doesn't count as it's a string addition anyway.

Basing on that I'd say remove all the colons (meme not included ;)

Revision history for this message
Akihiro Motoki (amotoki) wrote :

I see. It makes sense to me.

It seems better to fix in Havana.

Changed in horizon:
milestone: icehouse-1 → havana-rc1
assignee: nobody → Akihiro Motoki (amotoki)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48193

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/48193
Committed: http://github.com/openstack/horizon/commit/c99d07a15d9a82c31249cda13676484875823e7a
Submitter: Jenkins
Branch: master

commit c99d07a15d9a82c31249cda13676484875823e7a
Author: Akihiro MOTOKI <email address hidden>
Date: Wed Sep 25 16:05:24 2013 +0900

    Remove colon in item names in LBaaS detail page

    Also changes the followings for consistency with other pages:
    - Replace "Tenant ID" with "Project ID"
    - Show '-' when name or description is empty
    - Apply yesno filter for True/False field
    - Rearrange field order in pool and VIP details

    Change-Id: I82a533cee61dee148aac8872868effd78e46cc45
    Closes-Bug: #1230057

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.