[trunk] sale.order.line.make.invoice and purchase.order.line.invoice are impossible to extend

[Alexandre Fayolle - camptocamp]

The code in the two wizards sale.order.line.make.invoice and purchase.order.line.invoice needs fixing:

* it uses inner function to create the invoices and invoice lines, which makes it impossible to extend using the standard openerp practices (_inherit + super())
* it bypasses the _prepare_invoice_line methods of sale order and purchase orders

the net effect is that the customizations need to be written twice, and one of the places is awkward (requires complete rewrite of the wizard implementation, which in turns breaks separation of concern through different modules extending the same object)

[Amit Parik (amit-parik)]

Hello Alexandre,

Would you please explain this with complete example. So I can do a test on it.

Thank you

[Launchpad Janitor (janitor)]

[Expired for OpenERP Addons because there has been no activity for 60 days.]

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Sorry, I missed the request for clarification

Suppose I want to extend sale orders to e.g. add a field on sale.order.lines which needs to be processed when creating invoices. For example I add a field 'special_offer' on the sale.order.line and a field 'special_offer' on the account.invoice.line and I want the value of the field in the sale order line to be copied to the account invoice line when the invoice is generated.

As long as the default process for invoice generation is used, I can override in my model the _prepare_order_line_invoice_line method of sale.order and be happy.

But if my customer uses the sale.order.line.make.invoice wizard, then my customizations are not processed. And to fix the wizard I need to make deep changes because of the inner function which cannot be overridden and these changes are duplications of what I have in _prepare_order_line_invoice_line which is a Bad Thing.

Thanks for taking this into account at least in trunk.

[Amit Patel (amitkumarnpatel)]

Hello,
          I tested this senario but i got the same problem while overriding the '_prepare_order_line_invoice_line' method.

Thanks