SystemExit exception should be logged in neutron

[Xiang Hui]

OS : RHEL6.4
OpenStack version ：Havana

Config /etc/neutron/l3-agent.ini as below:

# L3 requires that an interface driver be set. Choose the one that best
# matches your plugin.
# interface_driver =

# Example of interface_driver option for OVS based plugins (OVS, Ryu, NEC)
# that supports L3 agent
# interface_driver = neutron.agent.linux.interface.OVSInterfaceDriver

Then start neutron-l3-agent :
service neutron-l3-agent start

The result is :
[root@xianghui ~]# service neutron-l3-agent start
Starting neutron-l3-agent: [ OK ]
[root@xianghui ~]# ps -ef|grep neutron-l3-agent
root 28989 6164 0 04:38 pts/2 00:00:00 grep --color=auto neutron-l3-agent

Actually, neutron-l3-agent isn't been started, but there's no log can be tracked both in user interface or in /var/log/neutron/l3-agent.log.

[ZhiQiang Fan (aji-zqfan)]

actually, there is a message printed in screen immediately when l3 fails:
An interface driver must be specified

so the bug title is not very suitable, however, i think logging this error makes sense, because sometimes operator may modify config files and reboot at once but may ignore this screen message when system restart, so log is needed

i think you can modify the title to 'systemExit exception should be logged in l3_agent' (and you can make a universal change for all systemExit in neutron not only in l3, this is optianal)

mark as comfirm

[Xiang Hui (xianghui)]

@ZhiQiang Fan, In my env, RHEL 6.4, no message being printed, the step and result just same as below:

[root@xianghui ~]# service neutron-l3-agent start
Starting neutron-l3-agent: [ OK ]
[root@xianghui ~]# ps -ef|grep neutron-l3-agent
root 28989 6164 0 04:38 pts/2 00:00:00 grep --color=auto neutron-l3-agent

If run neutron-l3-agent like /usr/bin/neutron-l3-agent, then the message "An interface driver must be specified" comes out to the screen, the difference maybe caused by the different OS ?

But I do agree with you about "operator may ignore this screen message when system restart" and change the title to be a more general one.

Thanks, appreciate it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47799
Committed: http://github.com/openstack/neutron/commit/03f39f10cc97db7a1a4bd5b0b9c5cf11dcd604aa
Submitter: Jenkins
Branch: master

commit 03f39f10cc97db7a1a4bd5b0b9c5cf11dcd604aa
Author: Hui HX Xiang <email address hidden>
Date: Mon Sep 23 02:04:57 2013 -0700

    Add error log for SystemExit in l3-agent

    The SystemExit exception should be logged in l3-agent, the
    operator may miss the useful exception messages to debug.

        * Add error log for SystemExit in l3-agent.
        * Add unit test for None and Wrong interface_driver.

    Closes-Bug #1229105

    Change-Id: I9ac60a528c1e88827078d552a30c8d571066d21c