Resource tracking updates PCI stats when they are not supported by the underlying driver

Bug #1228872 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Gary Kotton

Bug Description

At the moment only libvirt supports resource tracking. In the case that the host does not report the pci_stats then the data structure will be updated and there will be writes to the database. This will be done even though the data is not retuned from the host.
It is a waste of cycle and valuable resoures

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/47744

Changed in nova:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Henry Gessau (gessau)
summary: - Resource tracking updates PIC stats when they are not supported by the
+ Resource tracking updates PCI stats when they are not supported by the
underlying driver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/47744
Committed: http://github.com/openstack/nova/commit/6bb5c7302f67d130af2c92da0e1b98164ca46697
Submitter: Jenkins
Branch: master

commit 6bb5c7302f67d130af2c92da0e1b98164ca46697
Author: Gary Kotton <email address hidden>
Date: Sun Sep 22 07:51:44 2013 -0700

    Only update PCI stats if they are reported from the host

    Not all drivers and hosts may report PCI stats. These should only
    be updated if they are actually reported. This will save valuable cycles
    and not have any unnecessary database access.

    Fixes bug: 1228872

    Change-Id: I3e0170638f3820422dbdea5dfb9e02b2de2ceacd

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → havana-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.