nova-network should bring interfaces up before enslaving to a bridge

[Dan Smith]

Nova network enslaves interfaces to its bridge during setup, but does not ensure that those interfaces are up. In the case where you have a dedicated nic with no address that is unmanaged by the OS, it will be down at boot and nova-network will not bring it up when enslaving, which makes it non-functional until that happens.

A simple "ip link set $dev up" should do it if it's down and be a no-op otherwise.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47588

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47588
Committed: http://github.com/openstack/nova/commit/29de4dbb053d6ad886ca295d5dbcf6b646805f53
Submitter: Jenkins
Branch: master

commit 29de4dbb053d6ad886ca295d5dbcf6b646805f53
Author: Dan Smith <email address hidden>
Date: Fri Sep 20 07:59:43 2013 -0700

    Bring up interface when enslaving to a bridge

    Right now, if the interface to be used for a nova-network bridge is
    not already up, nova-network will enslave it and leave it down,
    which is not very helpful. Since an interface for this purpose is
    likely to be left unconfigured by the base OS, expecting it to be
    up is not ideal.

    Change-Id: I14564c0bcb55b9dd427ccaa8fb217e38121d4b71
    Closes-bug: 1228183