Change how we test fwts to use the recommended tests by upstream
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
High
|
Daniel Manrique |
Bug Description
We need to modify the tests we run in fwts.
Tests to remove:
crs
dmicheck
fan
hda_audio
maxreadreq
microcode
os2gap
osilinux
Tests to add:
acpidump
mpcheck
=== Reasons given by the FWTS team ===
crs: in summary, it checks BIOS date (newer than 2007). Most, if not
all, of systems should be newer than this.
dmicheck: DMI data are mostly information only and has no impacts. In
addition, many DMI data are written in production line and many of our
prototype OEM systems will have no such data. That's why we see lots
of errors saying DMI contains "defaults".
fan: many OEM uses EC to control fans and BIOS's interface (code) are
irrelevant. Passing the tests is great but failure may not tell us
much.
hda_audio: HDA pins vary by hardware designs. As we don't compare with
the hardware, this may not be applicable.
maxreadreq: The PCIe registers are often "read-only" and it fails this test.
microcode: This only compares microcode in kernel vs. in BIOS. BIOS
doesn't advance with time but kernel does. Newer in Kernel can be an
advantage but this does not make BIOS incapable.
os2gap: OS2 is no longer a concern in modern systems.
osilinux: Most BIOS implements _OSI("Linux") even though they are
don't-care (because we don't let ODM to use them). This makes the test
insufficient.
Related branches
- Jeff Lane : Approve
-
Diff: 55 lines (+5/-9)2 files modifiedcheckbox-old/debian/changelog (+2/-0)
checkbox-old/scripts/fwts_test (+3/-9)
Changed in checkbox: | |
importance: | Undecided → High |
status: | New → Triaged |
tags: | added: scripts |
Changed in checkbox: | |
status: | Triaged → In Progress |
assignee: | nobody → Daniel Manrique (roadmr) |
milestone: | none → 2013-oct-11 |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |