Heat unit tests are missing a mock somewhere

Bug #1227962 reported by Clint Byrum
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Clint Byrum

Bug Description

I noticed this in my squid log while running heat unit tests:

1379645655.134 2125 192.168.122.1 TCP_MISS/503 3924 POST http://server.test:5000/v2.0/tokens - DIRECT/server.test text/html
1379645655.228 0 192.168.122.1 TCP_MISS/503 3924 POST http://server.test:5000/v2.0/tokens - DIRECT/server.test text/html

We need to track down where this is coming from and mock/fake it out.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53533

Changed in heat:
assignee: nobody → Clint Byrum (clint-fewbar)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/53534

Steven Hardy (shardy)
Changed in heat:
milestone: none → icehouse-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/53533
Committed: http://github.com/openstack/heat/commit/5d1942f85adb75cdf8fcfeb564a195b6e83ae516
Submitter: Jenkins
Branch: master

commit 5d1942f85adb75cdf8fcfeb564a195b6e83ae516
Author: Clint Byrum <email address hidden>
Date: Thu Oct 24 00:59:17 2013 -0700

    Stub out unmocked keystone auth in signal tests

    While these tests do setup a mock for keystoneclient, one of the tests
    clears out these stubs before exitting to avoid needing to stub out
    things stack_delete_after will do. However, stack_delete_after will
    trigger a call to keystoneclient which leads to unmocked calls trying to
    reach server.test from inside the tests. These failures go undetected
    because they are after the test, and nothing is checking for error
    events in this phase.

    Change-Id: I608e0b5a263587d5151b4cb4ce3f03e289c4bdca
    Partial-Bug: #1227962

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/53534
Committed: http://github.com/openstack/heat/commit/93f44a2b535f2a22a8e476ec7eaa8f042e2c627f
Submitter: Jenkins
Branch: master

commit 93f44a2b535f2a22a8e476ec7eaa8f042e2c627f
Author: Clint Byrum <email address hidden>
Date: Thu Oct 24 01:03:49 2013 -0700

    Stub out unmocked keystone in test_engine_service

    Keystone needs to be mocked out whenever stacks may do something that
    triggers authentication. In this case failures to auth would not result
    in a failure of the test because we are not asserting the end state of
    the stack or the list of events we expect.

    Change-Id: I401971cfc984bd71c611eae70aeb33b2f5a3c8c6
    Closes-Bug: #1227962

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.