bad request for lswitches created through NVPAdvancedPlugin

[Armando Migliaccio]

Line https://github.com/openstack/neutron/blob/master/neutron/plugins/nicira/vshield/edge_appliance_driver.py#L628

should do truncation to avoid seeing errors like these:

2013-09-19 16:39:14.321 22194 TRACE neutron.plugins.nicira.dhcp_meta.rpc RequestBad: Request https://10.24.106.219/api/ws.v1/lswitch is Bad, response {"details":"Remote call failed","errorCode":600,"rootCauseString":"Remote call failed; nested exception is org.springframework.web.client.HttpClientErrorException: 400 Bad Request"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47507

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47507
Committed: http://github.com/openstack/neutron/commit/2a762867b2c5b67c5790d70e94c801d7d2f3f00c
Submitter: Jenkins
Branch: master

commit 2a762867b2c5b67c5790d70e94c801d7d2f3f00c
Author: armando-migliaccio <email address hidden>
Date: Thu Sep 19 17:27:29 2013 -0700

    Ensure names are truncated to accommodate NVP limit

    Switches created through Advanced Plugin should have
    their name truncated as well. To this aim, move things
    around to avoid awkward imports or code duplications

    Fixes bug #1227927

    Change-Id: I3cc69356227d3bd63603ee1e53d82e6561f4cad0