Hotkey dialog does not show stock GTK icons

Bug #1227368 reported by Peter TB Brett
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Medium
Peter TB Brett

Bug Description

The hotkey dialog show's gschem's custom icons, but omits stock GTK icons (i.e. most of them).

Tags: gschem
Peter TB Brett (peter-b)
Changed in geda:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Peter TB Brett (peter-b)
milestone: none → 1.9.1
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 25625af959da02723fc6b3800616eab6bf002401
http://git.geda-project.org/geda-gaf/commit/?id=25625af959da02723fc6b3800616eab6bf002401

commit 25625af959da02723fc6b3800616eab6bf002401
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Show stock icons in hotkeys dialog.

    Use GschemCellRendererIcon to display icons in list of hotkeys.

    Closes-bug: lp-1227368

Changed in geda:
status: In Progress → Fix Committed
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

A commit was made which affects this bug
git master commit 89d51ea544420506b91c3ac3d643a5c365cb807b
http://git.geda-project.org/geda-gaf/commit/?id=89d51ea544420506b91c3ac3d643a5c365cb807b

commit 89d51ea544420506b91c3ac3d643a5c365cb807b
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Add GschemCellRendererIcon class.

    In gschem we'd like to be able to associate a single icon name with
    each action. If the name matches a stock icon, we'd like to show it,
    but if not we'd like to fall back to looking up the icon in the
    current icon theme.

    Unfortunately, this behaviour isn't possible when using a
    GtkCellRendererPixbuf: you have to *either* use "icon-name" *or*
    "stock-id". The GschemCellRendererIcon subclasses
    GtkCellRendererPixbuf and provides the desired fallback behaviour via
    its "icon-id" property.

    Affects-bug: lp-1227368

Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

A commit was made which affects this bug
git master commit 72c030d26c9331e113190910b4db6903c767c67a
http://git.geda-project.org/geda-gaf/commit/?id=72c030d26c9331e113190910b4db6903c767c67a

commit 72c030d26c9331e113190910b4db6903c767c67a
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    gschem: Fix hotkey icon display more elegantly.

    Instead of creating a whole new GtkCellRenderer subclass, we could
    just connect into the "notify::stock-id" signal and rewrite the
    GtkCellRendererPixbuf's properties on the fly. This is a much
    lighter-weight solution!

    This reverts commit 89d51ea544420506b91c3ac3d643a5c365cb807b.
    This reverts commit 25625af959da02723fc6b3800616eab6bf002401.

    Affects-bug: lp-1227368

Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.