Instance object makes assumptions about DB backend

Bug #1227251 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Chris Behrens

Bug Description

The instance object code makes certain assumptions about the DB backend. Specifically, it assumes that 'info_cache' and 'security_groups' are always joined and never need to be included in 'columns_to_join' DB API calls.

Chris Behrens (cbehrens)
Changed in nova:
status: New → In Progress
assignee: nobody → Chris Behrens (cbehrens)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/47662

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/47662
Committed: http://github.com/openstack/nova/commit/19953cee68092fa93490320d0ebcac3cf19f5fac
Submitter: Jenkins
Branch: master

commit 19953cee68092fa93490320d0ebcac3cf19f5fac
Author: Chris Behrens <email address hidden>
Date: Thu Sep 19 17:51:16 2013 +0000

    Fix Instance object assumptions about joins

    The Instance object was assuming that security_groups and info_cache
    were always joined for single instance_get() type queries. This is a poor
    assumption to make. The object should explicitly ask for info_cache and
    security_groups to be included in the DB object when necessary.

    Also, we should actually fix sqlalchemy api to not join these always, but
    that's probably too large of a change right now. Instead, make sure we
    don't ask to join them twice in the same query.

    Fixes bug 1227251

    Change-Id: Ib39a3d041904fb5ecebbe152f2fede135a0cdb6f

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → havana-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.