msgstr in English PO files causes wrong source lang strings in Transifex

Bug #1226428 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

If POT files contains translated messages (msgstr) different from the original strings, Transifex seems to use msgstr rather than msgid as index, and this leads to incorrect source language strings in Transifex. [1]
After uploading POT files without any msgstr to Transifex, we confirm this problem is fixed.
POT files should have empty msgstr to avoid this issue.

http://lists.openstack.org/pipermail/openstack-i18n/2013-September/000103.html

Tags: i18n
Revision history for this message
Akihiro Motoki (amotoki) wrote :

This blocks the translation work, so I marked the important as Medium.

The fix is very simple: to remove English PO files in horizon repository once and then run ./run_tests.sh --makemessages to regenerate English PO files.

Changed in horizon:
importance: Undecided → Medium
milestone: none → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46884

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/46884
Committed: http://github.com/openstack/horizon/commit/e5acb7cba188caf61b2e7704c033d05d96a63298
Submitter: Jenkins
Branch: master

commit e5acb7cba188caf61b2e7704c033d05d96a63298
Author: Akihiro MOTOKI <email address hidden>
Date: Tue Sep 17 14:20:13 2013 +0900

    Regenerate POT (English PO) files

    If POT files contains translated messages, Transifex seems to use
    msgstr rather than msgid as index, and this leads to incorrect
    source language strings in Transifex [1].
    POT files should not have any strings in msgstr to avoid this problem.

    This commit regenerates POT files from scratch.

    [1] http://lists.openstack.org/pipermail/openstack-i18n/2013-September/000103.html

    Closes-Bug: #1226428
    Change-Id: I9aa11323edbfd98b95bbc2c26be337cc77df5e87

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.