Improvement of "import" statement in template file

Bug #1226427 reported by Noboru Arai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Noboru Arai

Bug Description

In "horizon/conf/panel_template/url.py", "import" statement contradicts the following coding rule.
 ・Do not import more than one module per line
 *)https://github.com/openstack-dev/hacking/blob/master/HACKING.rst

url.py is used as template file,when "run_test.sh -m startpanel" is executed.

It is desirable to divide an "import" statement in a url.py beforehand.

Noboru Arai (arai-h)
Changed in horizon:
assignee: nobody → Noboru Arai (arai-h)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/46887
Committed: http://github.com/openstack/horizon/commit/bfa506e7eb9a8683e58c0aea1487bfea1cc48d54
Submitter: Jenkins
Branch: master

commit bfa506e7eb9a8683e58c0aea1487bfea1cc48d54
Author: Noboru Arai <email address hidden>
Date: Tue Sep 17 15:50:04 2013 +0900

    divides "import" statement in a url.py

    url.py is used as template file,when "run_test.sh -m startpanel" is executed.

    It is desirable to divide an "import" statement in a url.py beforehand.

    Change-Id: Ibc50e3efbae0d2696d796516a1387633e06cc060
    Closes-Bug: #1226427

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.