glance/store/swift just does raise instead of reraising the exception

Bug #1226258 reported by Nikhil Komawar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Sridevi Koushik

Bug Description

ERROR glance.api.v1.upload_utils [x-x-x-x] Failed to upload image
TRACE glance.api.v1.upload_utils Traceback (most recent call last):
TRACE glance.api.v1.upload_utils File "glance/api/v1/upload_utils.py", line 85, in upload_data_to_store
TRACE glance.api.v1.upload_utils image_meta['size'])
TRACE glance.api.v1.upload_utils File "glance/store/swift.py", line 382, in add
TRACE glance.api.v1.upload_utils raise
TRACE glance.api.v1.upload_utils TypeError: exceptions must be old-style classes or derived from BaseException, not NoneType

Changed in glance:
assignee: nobody → Sridevi Koushik (sridevik)
summary: - glance/store/swift just does raise instead of reraising the exeception
+ glance/store/swift just does raise instead of reraising the exception
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/47534

Changed in glance:
status: New → In Progress
Changed in glance:
importance: Undecided → Medium
importance: Medium → Low
milestone: none → icehouse-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/47534
Committed: http://github.com/openstack/glance/commit/5a95201bf34805c38836c7b81112efe3e3aa6d8a
Submitter: Jenkins
Branch: master

commit 5a95201bf34805c38836c7b81112efe3e3aa6d8a
Author: sridevik <email address hidden>
Date: Fri Sep 20 03:35:36 2013 -0500

    Swift store add should not use wildcard raise

    When there is an yield block in an except clause prior to wildcard raise,
    if the thread is re-scheduled, the raise generates a TypeError.
    Since the caught exception has NoneType, it causes a wrong exception(NoneType)
    to be raised.

    Fixes bug #1226258

    Change-Id: I6ce56d1943535279f2ad40c7978b1539ed638d57

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.