Edge service router status in PENDING_CREATE even though it is been created successfully

[Kaiwei Fan]

When creating a logic router using plugin NvpAdvancedPlugin with service_router=True, the Edge service router status sometimes show PENDING_CREATE even when the Edge is created successfully.

Also, if the plugin is restarted, deleting an logic router does not delete Edge router.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46959

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46959
Committed: http://github.com/openstack/neutron/commit/d731097843d0b031bcdf6a8d67548f4bdf733016
Submitter: Jenkins
Branch: master

commit d731097843d0b031bcdf6a8d67548f4bdf733016
Author: Kaiwei Fan <email address hidden>
Date: Mon Sep 16 15:02:34 2013 -0700

    Fix for status always in PENDING_CREATE for Edge service router

    The root cause is when deployment finished, we only update router status to
    active if the status is in pending create. The problem happens when the
    background sync thread update router status to active, so the status update
    for vcns_router_binding table is skipped. We fixed this by seperating
    checking and updating status for router and binding table.

    Also fixed an issue where Edge is not deleted if neutron service is
    restarted. The root cause is when neutron service restarts, the cache for
    router type is empty. And because we delete the router from db before
    we delete Edge, we're not able to locate the router from db to determine
    the router type. The fix is to use binding table to determine the router
    type.

    Also piggyback a missing attribute for updating Edge interface. It must have
    been removed by accident when resolving conflict during service plugin merge.

    Closes-Bug: #1226229
    Change-Id: I3d0639d245e71ea2a3faba70fef1a0ebb87e19fd