Error message for an invalid template

Bug #1226106 reported by Sahdev Zala
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Angus Salkeld

Bug Description

The 'heat stack-create' gives an error message if template is invalid but it doesn't tell anything about what's invalid or any other detail that can help user find the error(s) and fix the template.

openstack@plwdevstack:~/devstack$ heat stack-create hello --template-file=/home/openstack/hello-invalid-template.yaml --parameters="KeyName=heat_key"
ERROR: Template not in valid format

We may want to provide a more helpful message.

This is a wishlist.

Angus Salkeld (asalkeld)
Changed in heat:
assignee: nobody → Angus Salkeld (asalkeld)
status: New → Confirmed
importance: Undecided → Low
milestone: none → icehouse-1
importance: Low → Medium
Revision history for this message
Sahdev Zala (spzala) wrote :

I think the simplest recreate scenario would be,
parameters:
  KeyName:
     type: string
    description: Name of an existing key pair to use for the instance
which gives, "ERROR: Template not in valid format"
and doesn't provide any other info.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/51125

Changed in heat:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/51125
Committed: http://github.com/openstack/heat/commit/081e5046734162bd4576b6477dbb6f2c486ebacf
Submitter: Jenkins
Branch: master

commit 081e5046734162bd4576b6477dbb6f2c486ebacf
Author: Angus Salkeld <email address hidden>
Date: Mon Oct 14 09:47:46 2013 +1100

    Pass errors from *_format.parse() to the caller

    This gives the user a nice helpful error message, something like:

    ERROR: Template not in valid format: while parsing a block mapping
      in "<unicode string>", line 2, column 3:
          KeyName:
          ^

    Change-Id: I1c0aaa955981eec264e1ff3cc66ad15adc771e72
    Closes-bug: #1226106

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.