Wrong handling of Instance expected_task_state

[Kravchenko Pavel]

When Instance.save called the expected_task_state parameter passed to it in order to specify what is instance expected task state.
There many cases when we would expect that there no task state for the vm (task_state=None in db). The expected_task_state=None is overwritten by the default substitution in the save() arguments and due to this not passed correctly to the db.instance_update_and_get_original method call.

[Kravchenko Pavel (kravchenko-pavel)]

Fix proposed in https://review.openstack.org/#/c/46649

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46649
Committed: http://github.com/openstack/nova/commit/84a797ec8c801057fef7a3c30ab74426e4c3fbdc
Submitter: Jenkins
Branch: master

commit 84a797ec8c801057fef7a3c30ab74426e4c3fbdc
Author: Kravchenko Pavel <email address hidden>
Date: Mon Oct 28 22:09:43 2013 +0200

    Wrong handling of Instance expected_task_state

    When Instance.save called the expected_task_state parameter can be
    passed to it in order to specify what is the expected task state.
    There many cases when we would expect that there no task state
    for the vm (task_state=None in db). Currently the
    expected_task_state=None is overwritten by the default substitution in
    the save() arguments and due to this not passed correctly to the
    db.instance_update_and_get_original method call.

    Closes-Bug: #1225659

    Change-Id: I84fd2f7e2c50c5f34c84f713d6afc040524a8078