floating-ips API extension doesn't handle NeutronClientException

[Mathew Odden]

While testing some error message responses on the Nova floating-ips API extension, I found that if an IP is requested from a pool that has no more IPs and if the OpenStack is configured to use Neutron, the server throws back an HTTP 500 because the extension doesn't handle the NeutronClientException. The extension looks like it expects a Nova exception for not enough floating IPs instead.

Seems like the extension just needs to be updated.

[Mathew Odden (locke105)]

Exception handling for not enough IPs is currently handled here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/floating_ips.py#L161

[Neetu Jain (nutshi)]

I can look into it with some guidance .. ( this will be my first bug fix)

[Neetu Jain (nutshi)]

seems like we need to import

from neutronclient.common import exceptions as n_exc

and then handle
/github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/floating_ips.py#L161

by adding
except n_exc.NeutronClientException:

is that correct?

[Christopher Yeoh (cyeoh-0)]

Fix has been commited here 8cd0a4120649d7dfa067731c7018afcfa5c7f833