Tests don't pass on OS X due to OpenSSL 0.9.8x

Bug #1225084 reported by Alex Gaynor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Fix Released
Low
Victor Silva

Bug Description

http://paste.openstack.org/show/47022/ contains all of the failure tracebacks. Some of these look similar to #1190054, however the patch on https://review.openstack.org/#/c/46535/ , which does resolve the failures on 32-bit, does not cause them all to pass on OS X. The exact cause of the failures isn't yet known.

This is OS X 10.8 (64-bit)

Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/46535
Committed: http://github.com/openstack/python-keystoneclient/commit/2fdbcbd06cfa6fd4348bc3752554331651717c87
Submitter: Jenkins
Branch: master

commit 2fdbcbd06cfa6fd4348bc3752554331651717c87
Author: Dolph Mathews <email address hidden>
Date: Fri Sep 13 11:29:49 2013 -0500

    Set example timestamps to 2038-01-18T21:14:07Z

    This timestamp is the last possible moment that can be represented on
    32-bit systems as an integer.

    As a consequence of revising the JSON examples, the corresponding PEM
    files must be re-generated as well.

    Change-Id: Ic6014c08b4545db036605beef1e6a8829ed347c4
    Related-Bug: 1190054
    Related-Bug: 1225084

Revision history for this message
Alex Gaynor (alex-gaynor) wrote : Re: Tests don't pass on OS X

The issue appears to be the fact that ``openssl cmd`` isn't a thing:

openssl:Error: 'cms' is an invalid command. [... usually openssl help ...]

But the retcode is still 0 (for reasons passing understanding), so that issue gets silently ignored.

Revision history for this message
Dolph Mathews (dolph) wrote :

Which version of openssl is installed?

I don't believe we support the version bundled with OS X (v0.9.8 or something?)-- you need to install 1.0+ (install http://brew.sh/ then `brew install openssl`)

Changed in python-keystoneclient:
status: Triaged → Incomplete
Revision history for this message
Alex Gaynor (alex-gaynor) wrote :

This is OpenSSL 0.9.8x, I wonder if there's some way we can detect this (despite the bad status code) and give a better error message.

Revision history for this message
Dolph Mathews (dolph) wrote :

i'd suggest writing a test that does 'openssl version' and just ensures that OS X's version isn't present?

Changed in python-keystoneclient:
importance: Medium → Low
status: Incomplete → Triaged
Dolph Mathews (dolph)
summary: - Tests don't pass on OS X
+ Tests don't pass on OS X due to OpenSSL 0.9.8x
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/123619

Changed in python-keystoneclient:
assignee: nobody → Victor Silva (victsou)
status: Triaged → In Progress
Changed in python-keystoneclient:
assignee: Victor Silva (victorsilva) → Rodrigo Duarte (rodrigodsousa)
Changed in python-keystoneclient:
assignee: Rodrigo Duarte (rodrigodsousa) → Victor Silva (victorsilva)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/123619
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=7d289eb79eef13e73f01a5a48df5ce1b576a8dc2
Submitter: Jenkins
Branch: master

commit 7d289eb79eef13e73f01a5a48df5ce1b576a8dc2
Author: Victor Silva <email address hidden>
Date: Tue Sep 23 23:27:48 2014 -0300

    Explicit complaint about old OpenSSL when testing

    Running the tests with an old version of OpenSSL
    results in many tests breaking without any hints
    of the real cause. This handles that explictly,
    stopping execution whenever the version is older
    than 1.0 and exiting with an informative message.

    Co-Authored-By: Rodrigo Duarte Sousa <email address hidden>
    Closes-Bug: 1225084

    Change-Id: I55e151d3fb4ddbe5ee4bf64bfdc597b4da73f6bb

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Changed in python-keystoneclient:
milestone: none → 0.11.2
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.