FFe: Sync avis-client-c 1.2.4-7 (universe) from Debian unstable (main)

[Daniel Pocock]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

 affects ubuntu
 status new
 importance wishlist
 subscribe ubuntu-release
 done

Please sync avis-client-c 1.2.4-7 (universe) from Debian unstable (main)

Explanation of FeatureFreeze exception:
The avis C client is a build dependency for OpenMAMA, which brings
real-time market data processing to Ubuntu.

All changelog entries:

avis-client-c (1.2.4-7) unstable; urgency=low

  * Set LDFLAGS correctly for HURD

 -- Daniel Pocock <email address hidden> Thu, 05 Sep 2013 12:03:42 +0200

avis-client-c (1.2.4-6) unstable; urgency=low

  * Set LDFLAGS correctly for kFreeBSD

 -- Daniel Pocock <email address hidden> Thu, 05 Sep 2013 09:45:13 +0200

avis-client-c (1.2.4-5) unstable; urgency=low

  * disable automake extra-portability warnings

 -- Daniel Pocock <email address hidden> Tue, 03 Sep 2013 13:34:57 +0200

avis-client-c (1.2.4-4) unstable; urgency=low

  * control: specify section libs for libavis0
  * build deps

 -- Daniel Pocock <email address hidden> Tue, 03 Sep 2013 10:03:06 +0200

avis-client-c (1.2.4-3) unstable; urgency=low

  * copyright: add LGPL-3

 -- Daniel Pocock <email address hidden> Mon, 02 Sep 2013 09:59:18 +0200

avis-client-c (1.2.4-2) unstable; urgency=low

  * Add version to watch file

 -- Daniel Pocock <email address hidden> Thu, 08 Aug 2013 18:30:11 +0200

avis-client-c (1.2.4-1) unstable; urgency=low

  * Initial packaging (Closes: #719083)

 -- Daniel Pocock <email address hidden> Thu, 08 Aug 2013 07:33:11 +0200

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJSMvzeAAoJEOm1uwJp1aqD0HYQAKGdik3E4TchxhyDyAB429Lg
MbOSzrDa3/fQrKcJOsVpV7reBdZIWxvBMrXwF3sDWCLIa3v1Z15fxgSInqmR2HtA
rq7w5rSO1g+5J0lmE/cMPhNCKyiSch5JHVD3caHnPByleefksjfTT19qIPzDfr/V
06rKM0o1TAduY+9v+Qlrw0EX7AQHrS4X+S2z1dKCbDUCuxDSY06AdH5dEDmz4dS0
Ef149jPIpHOnZMV+rLkYDE3KJ9v1L3q1ct5IzgtAg5Bfk/A//6xi64VUHHyQZYZP
tMSh0Eth6Oy4FLox0TJs30zubHTmhOS5K0bHpJ0lmFlzO139CTY/cwC3KOsnFxnc
CkTwnmGGpfE/BsSzqZ4LAFoumrd6UThct0i4pfZAefqPoKlWHYjv7GUksl6JSULY
+7M+k+fgnfv5ZNiJkFf0+8/8NnibpicLvFNU3l93VSir6zwuNJ0yf1oApd0E2IzV
pwk8D6MqxtwEfTG8+TBeHRTNEigLQwWgom5D1NmZJQbDkVac6R86pTTpbC2V2CxJ
PPUGkmXx4EfWINrR0rQ7YNpUQktH4dq8OgRcAUdD+iRn2oEq7J/C7GQ+641RL5w1
myDRwN83EgWxy8FEZpTI/ioyEZs8g3Bl4KPVQidVEhewUelQktFxc3SfxvVMee0a
/jN4M/Bsqax/4GDYARYC
=119J
-----END PGP SIGNATURE-----

[Scott Kitterman (kitterman)]

Ack. Approved.

[Daniel Holbach (dholbach)]

This unfortunately fails to build for me on saucy amd64:

gcc -DHAVE_CONFIG_H -I. -I../../platforms/gnu_automake -I../../src/include -I../../src/lib -I../../packages/check/src -D_FORTIFY_SOURCE=2 -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -c check_uri.c
In file included from check_uri.c:22:0:
../../packages/check/src/check.h:197:27: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros]
 #define fail_unless(expr, ...)\
                           ^
../../packages/check/src/check.h:208:23: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros]
 #define fail_if(expr, ...)\
                       ^
../../packages/check/src/check.h:213:14: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros]
 #define fail(...) _fail_unless(0, __FILE__, __LINE__, "Failed" , ## __VA_ARGS__, NULL)
              ^
/bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -lm -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z,relro -Wl,-z,now -o tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o ../../src/lib/libavis.la ../../packages/check/src/libcheck.la
libtool: link: gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o -lm ../../src/lib/.libs/libavis.so ../../packages/check/src/.libs/libcheck.a -pthread
../../src/lib/.libs/libavis.so: undefined reference to `ceilf'
collect2: error: ld returned 1 exit status
make[4]: *** [tests] Error 1
make[4]: Leaving directory `/tmp/buildd/avis-client-c-1.2.4/src/test'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/tmp/buildd/avis-client-c-1.2.4/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/buildd/avis-client-c-1.2.4'
dh_auto_build: make -j1 returned exit code 2
make[1]: *** [override_dh_auto_build] Error 2

[Daniel Pocock (daniel-pocock)]

On 16/09/13 10:06, Daniel Holbach wrote:
> This unfortunately fails to build for me on saucy amd64:
>
> gcc -DHAVE_CONFIG_H -I. -I../../platforms/gnu_automake -I../../src/include -I../../src/lib -I../../packages/check/src -D_FORTIFY_SOURCE=2 -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -c check_uri.c
> In file included from check_uri.c:22:0:
> ../../packages/check/src/check.h:197:27: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros]
> #define fail_unless(expr, ...)\
> ^
> ../../packages/check/src/check.h:208:23: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros]
> #define fail_if(expr, ...)\
> ^
> ../../packages/check/src/check.h:213:14: warning: anonymous variadic macros were introduced in C99 [-Wvariadic-macros]
> #define fail(...) _fail_unless(0, __FILE__, __LINE__, "Failed" , ## __VA_ARGS__, NULL)
> ^
> /bin/bash ../../libtool --tag=CC --mode=link gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -lm -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z,relro -Wl,-z,now -o tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o ../../src/lib/libavis.la ../../packages/check/src/libcheck.la
> libtool: link: gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o -lm ../../src/lib/.libs/libavis.so ../../packages/check/src/.libs/libcheck.a -pthread
> ../../src/lib/.libs/libavis.so: undefined reference to `ceilf'

ceilf is from libm

I can see "-lm" is in the linker command line so it is almost correct.
Could you try running that command manually without -pthread at the
end? E.g.

cd src/test

gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o -lm ../../src/lib/.libs/libavis.so ../../packages/check/src/.libs/libcheck.a

and see if it works?

If not, could you please share the full config.status and config.log
files from the top level of the build tree?

[Daniel Holbach (dholbach)]

It doesn't work. Attaching the files.

[Daniel Pocock (daniel-pocock)]

On 16/09/13 11:45, Daniel Holbach wrote:
> ** Attachment added: "config.log"
> https://bugs.launchpad.net/ubuntu/+bug/1224928/+attachment/3823404/+files/config.log
>

Thanks. It seems unusual because exactly the same linker command line
succeeds on Debian but fails on Ubuntu.

Have other packages had similar problems? I've done a search in Google
and couldn't find any specific examples, except for people who blatantly
leave out "-lm", which is not the case here.

I've posted a query to the autoconf list

http://lists.gnu.org/archive/html/autoconf/2013-09/msg00007.html

[Daniel Holbach (dholbach)]

Maybe this is related to https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition?

[Daniel Pocock (daniel-pocock)]

On 16/09/13 12:50, Daniel Holbach wrote:
> Maybe this is related to
> https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition?
>

Could you try the gcc command again with "-lm" moved towards the end of
the command, like this:

cd src/test

gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o
.libs/tests tests.o check_messages.o check_security.o check_client.o
check_collections.o check_invoke.o check_uri.o
../../src/lib/.libs/libavis.so ../../packages/check/src/.libs/libcheck.a
-lm -pthread

[Daniel Holbach (dholbach)]

daniel@daydream:~/avis-client-c-1.2.4/src/test$ LC_ALL=C gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o ../../src/lib/.libs/libavis.so ../../packages/check/src/.libs/libcheck.a -lm -pthread
../../src/lib/.libs/libavis.so: undefined reference to `ceilf'
collect2: error: ld returned 1 exit status
daniel@daydream:~/avis-client-c-1.2.4/src/test$

[Daniel Pocock (daniel-pocock)]

On 16/09/13 13:48, Daniel Holbach wrote:
> daniel@daydream:~/avis-client-c-1.2.4/src/test$ LC_ALL=C gcc -Wall -pedantic -pthread -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/tests tests.o check_messages.o check_security.o check_client.o check_collections.o check_invoke.o check_uri.o ../../src/lib/.libs/libavis.so ../../packages/check/src/.libs/libcheck.a -lm -pthread
> ../../src/lib/.libs/libavis.so: undefined reference to `ceilf'
> collect2: error: ld returned 1 exit status
> daniel@daydream:~/avis-client-c-1.2.4/src/test$
>

I've looked more closely, it appears that one of the other libraries
used to create libavis.so was linked without explicit "-lm"

I've uploaded 1.2.4-8 which adds "-lm" for packages/hashtable/Makefile.am

The fix is in git, could you please try it and let me know if it works?
You can clone from:

   git clone git://git.debian.org/collab-maint/avis-client-c.git

or just wait for it to appear through Debian unstable

[Daniel Holbach (dholbach)]

This fixes it. Let me know when you uploaded the fix and I'll sync it straight away.

[Daniel Pocock (daniel-pocock)]

On 16/09/13 14:30, Daniel Holbach wrote:
> This fixes it. Let me know when you uploaded the fix and I'll sync it
> straight away.
>

It has been uploaded already, it may just take a few minutes (or hours)
to pass through the FTP processing server

[Andrew Starr-Bochicchio (andrewsomething)]

Synced. Now an Archive Admin will need to nudge it through the new queue

https://launchpad.net/ubuntu/saucy/+queue