dmi_decode and smbios tests have been merged in fwts
Bug #1224923 reported by
Brendan Donegan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
High
|
Brendan Donegan | ||
Bug Description
These two tests have been merged into dmicheck. We need to remove them and add dmicheck. We also need to tie to the latest fwts version in the packaging to make sure the test script and fwts are in sync with each other.
Related branches
lp:~brendan-donegan/checkbox/fwts_remove_dmidecode_smbios
- Zygmunt Krynicki (community): Approve
-
Diff: 48 lines (+6/-3)3 files modifiedcheckbox-old/debian/changelog (+4/-0)
checkbox-old/debian/control (+1/-1)
checkbox-old/scripts/fwts_test (+1/-2)
Revision history for this message
| Daniel Manrique (roadmr) wrote | #1 |
| Changed in checkbox: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → 2013-oct-11 |
| tags: | added: scripts |
| Changed in checkbox: | |
| status: | Triaged → Fix Committed |
| importance: | Medium → High |
| assignee: | nobody → Brendan Donegan (brendan-donegan) |
| Changed in checkbox: | |
| milestone: | 2013-oct-11 → 2013-sep-27 |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
checkbox rev 2363 adds a suggests for a minimum version of fwts (the one where dmesg_common is gone and merged into klog). This is in checkbox trunk only for the moment. So work to do:
- Figure out which version of fwts has the dmicheck test encompassing the former dmi_decode and smbios
- Add that minimum version in the debian control file, *both* in checkbox trunk and in checkbox-packaging.
- Ensure we have at least that version in the PPA, for all supported releases, otherwise checkbox will be uninstallable from ppa leading to much suffering :(
- Modify the test scripts that reference these fwts tests, ensure they have dmicheck but not dmi_decode and smbios (in 2363 I modified pm_test and fwts_test).
I'll set as triaged based on the above.