I18N: cannot control the word order: 'You have selected "net1"'

Bug #1224846 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

When deleting a resource, the confirm form is displayed.
In the form, we have a message 'You have selected "net1".' but "You have selected" and a resource name is concatenated in the Javascript code. In some language, an object is placed before a verb, but translators cannot.

name_string = gettext("You have selected "); in horizon/static/horizon/js/horizon.tables.js L.143
should contain a substitution and ends with a period like

   You have selected "%s".

and related logic needs to be changed.

Tags: i18n
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I am not sure how to add a substitution in Javascript gettext at now.
If someone knows how, please take it. It is appreciated.

Revision history for this message
Julie Pichon (jpichon) wrote :
Changed in horizon:
status: New → Triaged
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Thanks. I got it fixed.

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
tags: added: i18n
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46484

Changed in horizon:
status: Triaged → In Progress
Julie Pichon (jpichon)
Changed in horizon:
milestone: none → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/46484
Committed: http://github.com/openstack/horizon/commit/8efb6a4d3b1b3510fad96986b43b089f0fd3b91f
Submitter: Jenkins
Branch: master

commit 8efb6a4d3b1b3510fad96986b43b089f0fd3b91f
Author: Akihiro MOTOKI <email address hidden>
Date: Fri Sep 13 21:01:57 2013 +0900

    Use substitutions in the messages of delete confirm form

    This allows translators to control the word order.

    Change-Id: I6aa894cbe92bc5d209cfb6c5cf869b318fca1225
    Closes-Bug: #1224846

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.