latest python-boto=2.13.0 has a bug which make unit tests fails

[Yaguang Tang]

Traceback (most recent call last):
  File "nova/tests/api/ec2/test_api.py", line 456, in test_authorize_revoke_security_group_cidr
    group.authorize('tcp', 80, 81, '0.0.0.0/0')
  File "/home/jenkins/workspace/gate-nova-python26/.tox/py26/lib/python2.6/site-packages/boto/ec2/securitygroup.py", line 207, in authorize
    src_group_group_id, dry_run=dry_run)
  File "/home/jenkins/workspace/gate-nova-python26/.tox/py26/lib/python2.6/site-packages/boto/ec2/securitygroup.py", line 115, in add_rule
    dry_run=dry_run
TypeError: add_grant() got an unexpected keyword argument 'dry_run'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46438

[Nikola Đipanov (ndipanov)]

I have reported the issue to upstream boto https://github.com/boto/boto/issues/1722

Until they fix it - we should cap it - so agreed with proposed patches.

Also this is affecting stable/grizzly aparently

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46438
Committed: http://github.com/openstack/nova/commit/bdac306b163a1d9d456e0598bfeb95391b48bb63
Submitter: Jenkins
Branch: master

commit bdac306b163a1d9d456e0598bfeb95391b48bb63
Author: Yaguang Tang <email address hidden>
Date: Fri Sep 13 15:26:53 2013 +0800

    Update requirements not to boto 2.13.0

    Latest boto 2.13.0 has a bug which lead to unit tests fails, before
    it's fixed avoid use this version.

    Fix bug #1224832

    Change-Id: I8a81adfc0cb0ad37d27b11db3c881735a099a95c

[wingwj (wingwj)]

Hi Tang,

I met the same error when I submitted the patch to Gerrit:
https://review.openstack.org/#/c/46272/

Your report is very helpful. Thanks~

Now I want to know how can I fix it in my branch?
Should I need to rebase it?

[wingwj (wingwj)]

Oh, I notice this patch is already merged to master now..

And I got the answer, I've already passed unit-tests both on my environment and Gerrit.

Thanks for the patch again~ :-)

[Yaguang Tang (heut2008)]

Just a recheck should be enough, I see other patches pass Jenkins after a
recheck.
在 2013年9月14日 上午12:26，"wingwj" <email address hidden>写道：

> Hi Tang,
>
> I met the same error when I submitted the patch to Gerrit:
> https://review.openstack.org/#/c/46272/
>
> Your report is very helpful. Thanks~
>
> Now I want to know how can I fix it in my branch?
> Should I need to rebase it?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1224832
>
> Title:
> latest python-boto=2.13.0 has a bug which make unit tests fails
>
> Status in OpenStack Compute (Nova):
> In Progress
> Status in OpenStack Compute (nova) grizzly series:
> Confirmed
> Status in OpenStack Core Infrastructure:
> New
>
> Bug description:
> Traceback (most recent call last):
> File "nova/tests/api/ec2/test_api.py", line 456, in
> test_authorize_revoke_security_group_cidr
> group.authorize('tcp', 80, 81, '0.0.0.0/0')
> File
> "/home/jenkins/workspace/gate-nova-python26/.tox/py26/lib/python2.6/site-packages/boto/ec2/securitygroup.py",
> line 207, in authorize
> src_group_group_id, dry_run=dry_run)
> File
> "/home/jenkins/workspace/gate-nova-python26/.tox/py26/lib/python2.6/site-packages/boto/ec2/securitygroup.py",
> line 115, in add_rule
> dry_run=dry_run
> TypeError: add_grant() got an unexpected keyword argument 'dry_run'
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova/+bug/1224832/+subscriptions
>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/46819

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/46862

[Alan Pevec (apevec)]

Not needed for Grizzly anymore, boto==2.13.3 was released https://jenkins02.openstack.org/job/periodic-nova-python27-stable-grizzly/15/console