Cinder

Argument of exception.InvalidInput are incorrect in iscsi.py and utils.py

Bug #1224790 reported by Kiyohiro Adachi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Kiyohiro Adachi
Cinder 2013.2 "havana"

Bug Description

cinder/volume/drivers/netapp/iscsi.py and
cinder/volume/drivers/netapp/utils.py are used as follows.

  raise exception.InvalidInput(data=msg)

I think the following is correct.

  raise exception.InvalidInput(reason=msg)

Kiyohiro Adachi (adachi)
Changed in cinder:
assignee: nobody → Kiyohiro Adachi (adachi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46418

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/46418
Committed: http://github.com/openstack/cinder/commit/996f7f949002d3d23048550b69579889f4e1c5a2
Submitter: Jenkins
Branch: master

commit 996f7f949002d3d23048550b69579889f4e1c5a2
Author: KIYOHIRO ADACHI <email address hidden>
Date: Fri Sep 13 14:13:53 2013 +0900

    Fixes the use of exception.InvalidInput with the wrong arguments

    A mapping key of 'message' in exception.InvalidInput is 'reason'.
    cinder/volume/drivers/netapp/iscsi.py and
    cinder/volume/drivers/netapp/utils.py had used 'data'.

    Change-Id: Ie40fc2f954984350827414edee9226adc80c8033
    Closes-Bug: #1224790

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.