Keep standard INNER joins above possible OUTERs

Bug #1224597 reported by Mike Rylander
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.5
Fix Released
Medium
Unassigned

Bug Description

We always join metabib.record_attr, and we always use an INNER join to the core table, so keep that join first. Likewise with the join to biblio.record_entry. Dynamic joins may be OUTER, though, and while join reordering in Postgres is smart, let's not give it the chance to fail.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/reorder-standard-joins

Tags: pullrequest
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-beta1 → 2.5.0-rc
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-rc → 2.5.1
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.5.1 → 2.5.2
status: New → Triaged
importance: Undecided → Medium
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.2 → 2.6.0-alpha1
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.6.0-alpha1 → 2.6.0-beta1
Revision history for this message
Ben Shum (bshum) wrote :

Going to try learning more about why this is a good idea, for my own knowledge and learning.

But the change sounds sensible and simple on paper.

Changed in evergreen:
assignee: nobody → Ben Shum (bshum)
Revision history for this message
Ben Shum (bshum) wrote :

Picked to master, rel_2_5, and rel_2_4.

Changed in evergreen:
assignee: Ben Shum (bshum) → nobody
status: Triaged → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
no longer affects: evergreen/2.4
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.