[vmware] InvalidURL nonnumeric port in read_write_ util with ipv6 host

[Davanum Srinivas (DIMS)]

Trying to use Nova VMware community driver in a pure ipv6 environment, running into this issue

2013-09-12 09:19:09.608 13034 ERROR nova.compute.manager [req-b1c13f77-09cf-4ac0-8d89-033b40189a54 2417695e037948d19ba56d81e97093dc 8ff56438ffa644a4b5fb7b5133bf7b5d] [instance: 2
49bd3e6-87fd-4168-9027-7d2edb7d4c37] Instance failed to spawn
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] Traceback (most recent call last):
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib/python2.6/site-packages/nova/compute/manager.py", line
1439, in _spawn
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] block_device_info)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/driver.py",
 line 604, in spawn
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] admin_password, network_info, block_device_info)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/vmops.py",
line 406, in spawn
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] _fetch_image_on_esx_datastore()
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/vmops.py",
line 317, in _fetch_image_on_esx_datastore
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] file_path=upload_vmdk_name)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/vmware_imag
es.py", line 133, in fetch_image
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] file_size)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/read_write_
util.py", line 128, in __init__
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] conn = httplib.HTTPSConnection(netloc)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib64/python2.6/httplib.py", line 1105, in __init__
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] HTTPConnection.__init__(self, host, port, strict, timeout)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib64/python2.6/httplib.py", line 661, in __init__
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] self._set_hostport(host, port)
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] File "/usr/lib64/python2.6/httplib.py", line 686, in _set_hostport
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] raise InvalidURL("nonnumeric port: '%s'" % host[i+1:])
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37] InvalidURL: nonnumeric port: 'cd47'
2013-09-12 09:19:09.608 13034 TRACE nova.compute.manager [instance: 249bd3e6-87fd-4168-9027-7d2edb7d4c37]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46277

[Shawn Hartsock (hartsock)]

This bug wasn't showing up in my reports because it wasn't tagged.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46277
Committed: http://github.com/openstack/nova/commit/022a4da0507924f57b563e7a5a09ea9d01e63c0e
Submitter: Jenkins
Branch: master

commit 022a4da0507924f57b563e7a5a09ea9d01e63c0e
Author: Davanum Srinivas <email address hidden>
Date: Thu Sep 12 09:35:18 2013 -0400

    [VMware] Fix problem transferring files with ipv6 host

    Need to protect the host name with '[' and ']' before
    we create a http/https connection

    Fixes LP# 1224479

    Change-Id: I8c2e58d3eb5e001eff3c9354c3cdc593469b23ac