Stack with resource OS::Neutron::Port could not be created when ip_address attr is not specified in fixed_ips property

Bug #1224472 reported by Serg Melikyan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Thomas Herve

Bug Description

Stack with resource OS::Neutron::Port could not be created when ip_address attr is not specified in fixed_ips property. From Neutron point of view, attribute ip_address of property fixed_ips is not required and can be ommited.

Steps to Reproduce:
1) Create template:
{
    "AWSTemplateFormatVersion": "2010-09-09",

    "Resources": {
        "port1": {
            "Type": "OS::Neutron::Port",
            "Properties": {
                "network_id": "9a456c59-85d2-4418-92db-a6940944cf99",
                "fixed_ips": [
                    {
                        "subnet_id": "private-subnet"
                    }
                ]
            },
            "Outputs": {
            }
        }
    }
}
2)Try to Launch this template

Expected result:
New port is created and available in Neutron

Observed result:
DEBUG neutronclient.v2_0.client [-] Error message: {"NeutronError": "Invalid input for fixed_ips. Reason: 'None' is not a valid IP address."} from (pid=798) _handle_fault_response /opt/stack/python-neutronclient/neutronclient/v2_0/client.py:1072

Thomas Herve (therve)
Changed in heat:
milestone: none → havana-rc1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46274

Changed in heat:
assignee: nobody → Serg Melikyan (smelikyan)
status: New → In Progress
Thomas Herve (therve)
Changed in heat:
assignee: Serg Melikyan (smelikyan) → Thomas Herve (therve)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/48259

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/48259
Committed: http://github.com/openstack/heat/commit/dcf594ce81b6f6c93d70faabaf93748189fc90e0
Submitter: Jenkins
Branch: master

commit dcf594ce81b6f6c93d70faabaf93748189fc90e0
Author: Thomas Herve <email address hidden>
Date: Wed Sep 25 15:59:48 2013 +0200

    Skip None values in fixed_ips when creating Port

    Neutron create port doesn't like when a None value is passed for
    fixed_ips data, the value needing to be skipped instead. This patch
    handles that problem for ip_address and subnet_id, as testing showed
    that subnet_id wasn't mandatory.

    Change-Id: I18a06cbad456eb75c41c299bc4c51c704d9dabc3
    Closes-Bug: #1224472

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.