I18n: Untranslated messages are displayed in the form of "Edit instance"

[Ying Chun Guo]

There are a few words displayed in the form of "Edit instance" without internationalized.

Go to the table of instances, select the action "Edit instance", the form will be displayed. There are two tabs in this form.

In the "Info" tab, the label "Name" is not internationalized.

In the "Security group" tab, there is a dropdown list under each security group attached to the instance. The only one item of the dropdown list is "Update security group role member". This item is not internationalized. The most interest thing is that the dropdown list is not displayed in English environment, but will be displayed in none-English environment.

[Julie Pichon (jpichon)]

Name should have a 'label=_("Name")' stanza added: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/update_instance.py#L107

Interesting about the Security groups string. I think it shouldn't be shown for any language, if it's not shown when displaying in English.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46270

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46270
Committed: http://github.com/openstack/horizon/commit/89c648e3b42f69aa757120461b0bc2b9767a5c3b
Submitter: Jenkins
Branch: master

commit 89c648e3b42f69aa757120461b0bc2b9767a5c3b
Author: Julie Pichon <email address hidden>
Date: Wed Sep 11 20:05:32 2013 +0100

    Internationalise a couple of forgotten strings

    Change-Id: Ia17cbcd7d5127ca83a925ce9f31bf095a23062e8
    Partial-Bug: #1224338
    Closes-Bug: #1224289

[Julie Pichon (jpichon)]

Note: the above patch fixed the missing "Name" translation, the issue on the security groups tab remains.

[Julie Pichon (jpichon)]

The additional drop-down is shown depending on whether "step.show_roles" is equal to "no" or not.

https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_workflow_step_update_members.html#L5

show_roles is a boolean, however the yesno filter is internationalised therefore "No" is translated into the target language and fails the "hide this if step.showroles is equals to 'No'" test.

Note there is no missing i18n string as far as I can see -- when this menu needs to be displayed, it shows role names as defined in other parts of the system (see e.g. Domains, Projects).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/46746

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46746
Committed: http://github.com/openstack/horizon/commit/f3fc4b419e9597727d945f68caeb21e03b3cbf10
Submitter: Jenkins
Branch: master

commit f3fc4b419e9597727d945f68caeb21e03b3cbf10
Author: Julie Pichon <email address hidden>
Date: Mon Sep 16 15:48:47 2013 +0100

    Make show_roles language independent

    A menu in the membership form was displayed depending on whether
    show_roles was equal to "No", however as the initial boolean value was
    passed through the Django yesno template filter which is
    internationalised, this would not work when using the dashboard in
    other languages.

    Change-Id: Ie58eb98590296b0c9f38b3c243c7c63327755fd9
    Closes-Bug: #1224338