No need to init testr in run_tests.sh

Bug #1224285 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kui Shi

Bug Description

    Don't need to init testr in run_tests.sh

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository, setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

Tags: tools
Kui Shi (skuicloud)
Changed in neutron:
assignee: nobody → Kui Shi (skuicloud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46199

Changed in neutron:
status: New → In Progress
Nachi Ueno (nati-ueno)
Changed in neutron:
importance: Undecided → Low
milestone: none → ongoing
tags: added: tools
Changed in neutron:
milestone: ongoing → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/46199
Committed: http://github.com/openstack/neutron/commit/3555240db39186cd4c47fc54417614252ededb06
Submitter: Jenkins
Branch: master

commit 3555240db39186cd4c47fc54417614252ededb06
Author: Kui Shi <email address hidden>
Date: Thu Sep 12 01:04:09 2013 +0800

    Don't need to init testr in run_tests.sh

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository, setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

    Fixes Bug #1224285

    Change-Id: Ia74d9fff92b8efba9b72e5c7387f761144daa193

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.