ZIP package installation (master branch)

Bug #1224063 reported by stratumnine
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mudlet
Fix Released
Critical
Chris

Bug Description

This does not affect Mudlet 2.1 - Only Mudlet from git.

Creation of subdirectories when using libzip to extract a ZIP package fails.
ZIP package installation fails to complete when a subdirectory was unable to be created.

Fix is here:
https://github.com/stratumnine/mudlet/commit/726a47fffe5b91999937dc5d38f8a5aa1738e7f5

description: updated
Revision history for this message
Vadim Peretokin (vperetokin) wrote :

Git package installation is broken - if the package has folders within it, it will just get stuck. The patch above is supposed to fix that.

Changed in mudlet:
milestone: none → 3.0
status: New → Confirmed
importance: Undecided → Critical
description: updated
Revision history for this message
stratumnine (stratumnine) wrote :

Patch was tested with a few different packages (some without folders and some with) and the ones with folders inside would get stuck resulting in having to close Mudlet, where upon re-opening it the package would not be installed. As soon as it encounters a folder inside a package, it would be unable to create that folder because the QDir was invalid.

After applying the patch, zip packages with folders inside of them install correctly.

Revision history for this message
Vadim Peretokin (vperetokin) wrote :

I think Chris applied this patch in his github repo already.

Changed in mudlet:
status: Confirmed → Fix Committed
Revision history for this message
Chris (chrismudlet) wrote :
Changed in mudlet:
assignee: nobody → Chris (chrismudlet)
Revision history for this message
Chris (chrismudlet) wrote :

Are we good to completely purge the quazip folder?

Revision history for this message
Vadim Peretokin (vperetokin) wrote : Re: [Mudlet-makers] [Bug 1224063] Re: ZIP package installation (master branch)

Yes.

Changed in mudlet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.