Cannot edit images without name

Bug #1223921 reported by Attila Fazekas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Kieran Spear

Bug Description

Create an image without a name:
1.
$ glance image-create --container-format bare --disk-format qcow2 --file /etc/passwd

2.
navigate to : http://<host>/project/images_and_snapshots/

3.
Image Name will be shown as '-'. Click to the More->Edit.

4.
Red error message will appear:
'Error: An error occurred. Please try again later. '

the horizon_access.log contains this type of access:
10.34.68.214 - - [11/Sep/2013:15:00:36 +0000] "GET /project/images_and_snapshots/8a32d6a9-06a0-4913-8451-c8ff9e6f82c3/update/ HTTP/1.1" 500 24083 "http://10.34.68.214/project/images_and_snapshots/" "Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0"

The horizon_error.log does not gets a new entry.

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

This is probably just a programming error in the form class somewhere. We should investigate for Havana RC1 and determine if it's a simple fix or not.

Changed in horizon:
importance: Undecided → Low
milestone: none → havana-rc1
status: New → Confirmed
Kieran Spear (kspear)
Changed in horizon:
assignee: nobody → Kieran Spear (kspear)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48169

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/48169
Committed: http://github.com/openstack/horizon/commit/9a0be2b0e0486e5aaf2323f59aa582d50fa6c033
Submitter: Jenkins
Branch: master

commit 9a0be2b0e0486e5aaf2323f59aa582d50fa6c033
Author: Kieran Spear <email address hidden>
Date: Wed Sep 25 10:47:13 2013 +1000

    Fix editing of nameless images

    We can't assume image.name is a valid attribute as Glance
    doesn't send it for images that don't have a name.

    This is a targeted fix to handle two cases where we access the name.
    Where the name is not available, this shows the ID instead.

    In the future we may want to look at wrapping images in our own class
    so we can clean up data as it is returned from the API.

    Change-Id: Ida50ce74efafff287a0189dc90aa529e80bd5961
    Closes-bug: 1223921

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.