Pay attention to the ORDER BY rupture_id

Bug #1223362 reported by Michele Simionato
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenQuake Engine
Fix Released
Critical
Michele Simionato

Bug Description

Ruptures are generated by different tasks. That means that they auto-incremental id they receive depends very much on the details of the distribution (i.e. the number of cores, the block_size, the way celery sends the tasks to the workers, etc).
If we rely on an ORDER BY rupture_id when performing a risk calculation, we are asking for trouble, since the same ruptures can come in different order in different computations, which means that the risk calculation will generate different numbers due to the inherent randomness of the ORDER BY, even if the master_seed is fixed. We should find a solution. For sure there is an ORDER BY rupture_id in the hazard_getters: we should look if there are others and find a general solution for the issue.

Changed in oq-engine:
importance: Undecided → High
Revision history for this message
Michele Simionato (michele-simionato) wrote :

We could use as rupture id the triple (ses_id, source_id, ordinal_of_the_rupture_generated_by_that_source).

Revision history for this message
Michele Simionato (michele-simionato) wrote :
Changed in oq-engine:
assignee: nobody → Michele Simionato (michele-simionato)
status: New → In Progress
Changed in oq-engine:
milestone: none → 1.0.1
importance: High → Critical
Changed in oq-engine:
status: In Progress → Fix Committed
Revision history for this message
Michele Simionato (michele-simionato) wrote :

https://github.com/gem/oq-nrmllib/pull/110 and https://github.com/gem/oq-engine/pull/1277 are also related to this ticket (the rupture tags enter in the GMF export files).

Changed in oq-engine:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.