Invalid exception message in create_volume_from_image.

Bug #1223198 reported by Kiyohiro Adachi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Kiyohiro Adachi

Bug Description

When the PowerVMFileTransferFailed occurs in
PowerVMLocalVolumeAdapter.create_volume_from_image, in some cases the
message is incorrect.

Tags: powervm
Kiyohiro Adachi (adachi)
Changed in nova:
assignee: nobody → Kiyohiro Adachi (adachi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45818

Changed in nova:
status: New → In Progress
Revision history for this message
Masayuki Igawa (igawa) wrote :

I think you should describe the details about 'in some cases the message is incorrect'.
How do you think?

Revision history for this message
Kiyohiro Adachi (adachi) wrote :

Sorry!
I thought when I found this problem to occur in the case of more than one.
But take a closer look when I want to create a patch, after all conditions was one.
It is when the following code failed.

        # Calculate file size in multiples of 512 bytes
        output = self.run_vios_command("ls -o %s|awk '{print $4}'" %
                                  final_path, check_exit_code=False)

Thank you for your comment.

Matt Riedemann (mriedem)
tags: added: powervm
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/45818
Committed: http://github.com/openstack/nova/commit/911fe582ec68a1a2df0abb2cb11352c9106842c2
Submitter: Jenkins
Branch: master

commit 911fe582ec68a1a2df0abb2cb11352c9106842c2
Author: KIYOHIRO ADACHI <email address hidden>
Date: Tue Sep 10 15:35:24 2013 +0900

    Fixes the usage of PowerVMFileTransferFailed class

    If it fails in the process of "Calculate file size in multiples of 512
    bytes", the exception.PowerVMFileTransferFailed message is illegal.
    "KeyError: u'file_path'" is occurs when there is no argument.

    Change-Id: I15a7467bbc103f683d82949dc0892210cd63c4b6
    Closes-Bug: #1223198

Changed in nova:
status: In Progress → Fix Committed
Matt Riedemann (mriedem)
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.