Midonet plugin dhcp agent scheduling fails

[Bob Melander]

DHCP agent scheduling does not work in the Midonet plugin. The reason is that plugin.py has a typo (a missing comma):'

class MidonetPluginV2(db_base_plugin_v2.NeutronDbPluginV2,
                      l3_db.L3_NAT_db_mixin,
                      agentschedulers_db.AgentSchedulerDbMixin,
                      securitygroups_db.SecurityGroupDbMixin):

    supported_extension_aliases = ['router', 'security-group', 'agent' <------ Missing a comma (',') here
                                   'dhcp_agent_scheduler']

The result is that the 'agent' and 'dhcp_agent_scheduler' extensions are not loaded.

If a comma is added so the extension are indeed loaded then unit tests fail. This is because the plugin does not implement the functions in the DhcpAgentSchedulerDbMixin class (it seems to inherit only the base class of the mixin). The fix is likely just to change so that it uses that dhcp agent scheduling mixin.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45720

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45720
Committed: http://github.com/openstack/neutron/commit/98e16a06e463bdd83ba617fbb845f8b92852c24a
Submitter: Jenkins
Branch: master

commit 98e16a06e463bdd83ba617fbb845f8b92852c24a
Author: Mark McClain <email address hidden>
Date: Mon Sep 9 14:04:50 2013 -0400

    add missing comma to supported alias string list

    Fixes bug: 1222949

    Change-Id: Iac7f3b7605149e706e2ea8a30700dccd09f3c57e