perf: Dict lookup using pop()
Bug #1222935 reported by
Kurt Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zaqar |
Fix Released
|
Medium
|
Anthony J Russo |
Bug Description
Using pop() here seems to be unnecessary, since it doesn't matter whether or not 't' is left in claim:
'ttl': claim.pop('t'),:
Changed in marconi: | |
assignee: | nobody → Anthony J Russo (ajrusso39) |
Changed in marconi: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/50692 github. com/openstack/ marconi/ commit/ 503402b49b6d04d d88893cd61644f2 1c8b1781b8
Committed: http://
Submitter: Jenkins
Branch: master
commit 503402b49b6d04d d88893cd61644f2 1c8b1781b8
Author: Zhihao Yuan <email address hidden>
Date: Wed Oct 9 13:22:19 2013 -0400
fix: one less unnecessary modification
One of the mongo driver methods unnecessary pop()'ed a value
in the old dict while constructing a new dict.
Change-Id: Ief2190807cd044 3f9eeb238fe3e86 b756c3fbe41
Closes-Bug: 1222935