perf: Dict lookup using pop()

Bug #1222935 reported by Kurt Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Medium
Anthony J Russo

Bug Description

Using pop() here seems to be unnecessary, since it doesn't matter whether or not 't' is left in claim:

'ttl': claim.pop('t'),:

Changed in marconi:
assignee: nobody → Anthony J Russo (ajrusso39)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to marconi (master)

Reviewed: https://review.openstack.org/50692
Committed: http://github.com/openstack/marconi/commit/503402b49b6d04dd88893cd61644f21c8b1781b8
Submitter: Jenkins
Branch: master

commit 503402b49b6d04dd88893cd61644f21c8b1781b8
Author: Zhihao Yuan <email address hidden>
Date: Wed Oct 9 13:22:19 2013 -0400

    fix: one less unnecessary modification

    One of the mongo driver methods unnecessary pop()'ed a value
    in the old dict while constructing a new dict.

    Change-Id: Ief2190807cd0443f9eeb238fe3e86b756c3fbe41
    Closes-Bug: 1222935

Changed in marconi:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in marconi:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.