no tests for goose/client.NewPublicClient

Bug #1222693 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Go OpenStack Exchange
Invalid
Medium
Unassigned

Bug Description

The function "client.NewPublicClient" is used to create a goose Client object that doesn't handle authentication (used for stuff like public shared buckets, etc).
However, there are 0 calls inside the goose code base, and thus clearly no direct testing of its behavior.

The actual 'client' object that is being returned is shared with authenticatingClient so there is probably some functional coverage of the actual methods. But authenticatingClient overrides the 2 public functions MakeServiceURL and SendRequest, so there may actually be 0 coverage of goose/client.client.SendRequest

Tags: tech-debt
Revision history for this message
John A Meinel (jameinel) wrote :

I was wrong, I missed the tests in swift/live_test.go which sets up a public shared bucket and then creates a client into it. There aren't any unit tests for it, but we do at least have live coverage.

Changed in goose:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.